Issue 2539743002: Add more checks to kernel verifier.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2539743002: Add more checks to kernel verifier. (Closed)

Created:
4 years ago by asgerf

Modified:
4 years ago

Reviewers:
Kevin Millikin (Google)

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Add more checks to kernel verifier. We now check that classes and type parameters are not redeclared. The verify_test also verifies that its test harness has no errors, as this would make all the other tests useless. BUG= R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/640061d62e8f4fe32edf9bf3331116a051a9c395

Created: 4 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+83 lines, -35 lines)			Patch
	M	pkg/kernel/lib/verifier.dart	View		5 chunks	+24 lines, -7 lines	0 comments	Download
	M	pkg/kernel/test/verify_test.dart	View		3 chunks	+59 lines, -28 lines	0 comments	Download

Total messages: 5 (2 generated)

asgerf

4 years ago (2016-11-29 12:04:50 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
640061d62e8f4fe32edf9bf3331116a051a9c395 (presubmit successful).