MD Settings: Overhaul Easy Unlock Turn Off Dialog.

MD Settings: Overhaul Easy Unlock Turn Off Dialog.

Uses the more modern lazy-creation technique instead of doing manual
management of WebUIListeners. Simplifies code and fixes some edge cases.

BUG=595885
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/90965e32c0587843c43b2765e98a8530ef92a0de
Cr-Commit-Position: refs/heads/master@{#435441}

[tommycli, 2016-11-30 16:51:14]

Description was changed from

==========
MD Settings: Overhaul Easy Unlock Turn Off Dialog.

Uses the more modern lazy-creation technique instead of doing manual
management of WebUIListeners. Simplifies code and fixes some edge cases.

BUG=595885
==========

to

==========
MD Settings: Overhaul Easy Unlock Turn Off Dialog.

Uses the more modern lazy-creation technique instead of doing manual
management of WebUIListeners. Simplifies code and fixes some edge cases.

BUG=595885
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tommycli, 2016-11-30 16:52:43]

tommycli@chromium.org changed reviewers:
+ dpapad@chromium.org

[tommycli, 2016-11-30 16:52:43]

dpapad: PTAL, I tried to follow the lazily-created dialog technique that you
used elsewhere.

(To eliminate manual management of WebUI listeners)

[tommycli, 2016-11-30 16:52:59]

On 2016/11/30 16:52:43, tommycli wrote:
> dpapad: PTAL, I tried to follow the lazily-created dialog technique that you
> used elsewhere.
> 
> (To eliminate manual management of WebUI listeners)

This is already covered by the SettingsEasyUnlockBrowserTest btw.

[tommycli, 2016-11-30 16:53:03]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-30 16:53:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 18:40:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-30 18:40:13]

Dry run: This issue passed the CQ dry run.

[dpapad, 2016-11-30 20:07:44]

LGTM with nit.

https://codereview.chromium.org/2539733004/diff/1/chrome/browser/resources/se...
File
chrome/browser/resources/settings/people_page/easy_unlock_turn_off_dialog.js
(right):

https://codereview.chromium.org/2539733004/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/people_page/easy_unlock_turn_off_dialog.js:31:
browserProxy_: {
FWIW, we've started being OK with declaring browserProxies outside of Polymer
properties (see
https://cs.chromium.org/search/?q=%22browserProxy_:%22&p=1&sq=package:chromiu...).
There is no good reason to put anything in a Polymer property, if it is not
accessed by a data binding or HTML.

[tommycli, 2016-11-30 20:13:32]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-30 20:14:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tommycli, 2016-11-30 20:19:29]

thanks!

https://codereview.chromium.org/2539733004/diff/1/chrome/browser/resources/se...
File
chrome/browser/resources/settings/people_page/easy_unlock_turn_off_dialog.js
(right):

https://codereview.chromium.org/2539733004/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/people_page/easy_unlock_turn_off_dialog.js:31:
browserProxy_: {
On 2016/11/30 20:07:44, dpapad wrote:
> FWIW, we've started being OK with declaring browserProxies outside of Polymer
> properties (see
>
https://cs.chromium.org/search/?q=%22browserProxy_:%22&p=1&sq=package:chromiu...).
> There is no good reason to put anything in a Polymer property, if it is not
> accessed by a data binding or HTML.

Done.

[tommycli, 2016-11-30 20:31:54]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-30 20:33:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tommycli, 2016-11-30 20:34:00]

The CQ bit was unchecked by tommycli@chromium.org

[tommycli, 2016-11-30 20:34:00]

The CQ bit was checked by tommycli@chromium.org

[tommycli, 2016-11-30 20:34:01]

The patchset sent to the CQ was uploaded after l-g-t-m from dpapad@chromium.org
Link to the patchset: https://codereview.chromium.org/2539733004/#ps40001
(title: "fix copy pasta")

[commit-bot: I haz the power, 2016-11-30 20:34:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 22:14:11]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480538040774490,
"parent_rev": "70fa5fb78a95e4b08f279b93df673c09e63b1ea4", "commit_rev":
"4f41442f57a284fcb589839a2fbad5db29f3f7f7"}

[commit-bot: I haz the power, 2016-11-30 22:14:37]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-30 22:18:17]

Description was changed from

==========
MD Settings: Overhaul Easy Unlock Turn Off Dialog.

Uses the more modern lazy-creation technique instead of doing manual
management of WebUIListeners. Simplifies code and fixes some edge cases.

BUG=595885
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Overhaul Easy Unlock Turn Off Dialog.

Uses the more modern lazy-creation technique instead of doing manual
management of WebUIListeners. Simplifies code and fixes some edge cases.

BUG=595885
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/90965e32c0587843c43b2765e98a8530ef92a0de
Cr-Commit-Position: refs/heads/master@{#435441}
==========

[commit-bot: I haz the power, 2016-11-30 22:18:18]

Patchset 3 (id:??) landed as
https://crrev.com/90965e32c0587843c43b2765e98a8530ef92a0de
Cr-Commit-Position: refs/heads/master@{#435441}