Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Issue 2539733004: MD Settings: Overhaul Easy Unlock Turn Off Dialog. (Closed)

Created:
4 years ago by tommycli
Modified:
4 years ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Overhaul Easy Unlock Turn Off Dialog. Uses the more modern lazy-creation technique instead of doing manual management of WebUIListeners. Simplifies code and fixes some edge cases. BUG=595885 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/90965e32c0587843c43b2765e98a8530ef92a0de Cr-Commit-Position: refs/heads/master@{#435441}

Patch Set 1 #

Total comments: 2

Patch Set 2 : address comments #

Patch Set 3 : fix copy pasta #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -30 lines) Patch
M chrome/browser/resources/settings/people_page/easy_unlock_turn_off_dialog.js View 1 2 2 chunks +10 lines, -27 lines 0 comments Download
M chrome/browser/resources/settings/people_page/people_page.html View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/people_page/people_page.js View 3 chunks +14 lines, -1 line 0 comments Download

Messages

Total messages: 22 (15 generated)
tommycli
dpapad: PTAL, I tried to follow the lazily-created dialog technique that you used elsewhere. (To ...
4 years ago (2016-11-30 16:52:43 UTC) #3
tommycli
On 2016/11/30 16:52:43, tommycli wrote: > dpapad: PTAL, I tried to follow the lazily-created dialog ...
4 years ago (2016-11-30 16:52:59 UTC) #4
dpapad
LGTM with nit. https://codereview.chromium.org/2539733004/diff/1/chrome/browser/resources/settings/people_page/easy_unlock_turn_off_dialog.js File chrome/browser/resources/settings/people_page/easy_unlock_turn_off_dialog.js (right): https://codereview.chromium.org/2539733004/diff/1/chrome/browser/resources/settings/people_page/easy_unlock_turn_off_dialog.js#newcode31 chrome/browser/resources/settings/people_page/easy_unlock_turn_off_dialog.js:31: browserProxy_: { FWIW, we've started being ...
4 years ago (2016-11-30 20:07:44 UTC) #9
tommycli
thanks! https://codereview.chromium.org/2539733004/diff/1/chrome/browser/resources/settings/people_page/easy_unlock_turn_off_dialog.js File chrome/browser/resources/settings/people_page/easy_unlock_turn_off_dialog.js (right): https://codereview.chromium.org/2539733004/diff/1/chrome/browser/resources/settings/people_page/easy_unlock_turn_off_dialog.js#newcode31 chrome/browser/resources/settings/people_page/easy_unlock_turn_off_dialog.js:31: browserProxy_: { On 2016/11/30 20:07:44, dpapad wrote: > ...
4 years ago (2016-11-30 20:19:29 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2539733004/40001
4 years ago (2016-11-30 20:34:15 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-11-30 22:14:37 UTC) #20
commit-bot: I haz the power
4 years ago (2016-11-30 22:18:18 UTC) #22
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/90965e32c0587843c43b2765e98a8530ef92a0de
Cr-Commit-Position: refs/heads/master@{#435441}

Powered by Google App Engine
This is Rietveld 408576698