Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 2539713004: Update layout location documentation to reflect renames. (Closed)

Created:
4 years ago by wkorman
Modified:
4 years ago
Reviewers:
Xianzhu
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update layout location documentation to reflect renames. Follow-up to renames performed in http://crrev.com/2536453002 Committed: https://crrev.com/299d4047e12b7896fcfa2bd269f9b59ae6936298 Cr-Commit-Position: refs/heads/master@{#435684}

Patch Set 1 #

Total comments: 6

Patch Set 2 : Feedback. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -6 lines) Patch
M third_party/WebKit/Source/core/layout/README.md View 1 3 chunks +17 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/InlineBox.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
wkorman
4 years ago (2016-11-29 19:27:47 UTC) #2
Xianzhu
lgtm https://codereview.chromium.org/2539713004/diff/1/third_party/WebKit/Source/core/layout/README.md File third_party/WebKit/Source/core/layout/README.md (right): https://codereview.chromium.org/2539713004/diff/1/third_party/WebKit/Source/core/layout/README.md#newcode228 third_party/WebKit/Source/core/layout/README.md:228: For LayoutBox and LayoutInline classes and subclasses: s/LayoutInline/InlineBox/ ...
4 years ago (2016-11-29 23:36:30 UTC) #3
wkorman
https://codereview.chromium.org/2539713004/diff/1/third_party/WebKit/Source/core/layout/README.md File third_party/WebKit/Source/core/layout/README.md (right): https://codereview.chromium.org/2539713004/diff/1/third_party/WebKit/Source/core/layout/README.md#newcode228 third_party/WebKit/Source/core/layout/README.md:228: For LayoutBox and LayoutInline classes and subclasses: On 2016/11/29 ...
4 years ago (2016-12-01 18:53:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2539713004/20001
4 years ago (2016-12-01 18:54:07 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-01 20:07:14 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-01 20:10:30 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/299d4047e12b7896fcfa2bd269f9b59ae6936298
Cr-Commit-Position: refs/heads/master@{#435684}

Powered by Google App Engine
This is Rietveld 408576698