third_party/WebKit/Source/core/layout/LayoutObject.cpp - Issue 2539693002: Early-out from the prepaint tree walk

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutObject.cpp

Issue 2539693002: Early-out from the prepaint tree walk (Closed)

Patch Set: Address chrishtrs comments Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutObject.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutObject.cpp b/third_party/WebKit/Source/core/layout/LayoutObject.cpp

index 2049367d76af354817202b78d02a37dc94f97772..26ebeb2a4846a7567048e001f6965319a87db34c 100644

--- a/third_party/WebKit/Source/core/layout/LayoutObject.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutObject.cpp

@@ -2735,9 +2735,6 @@ void LayoutObject::willBeRemovedFromTree() {

void LayoutObject::setNeedsPaintPropertyUpdate() {

m_bitfields.setNeedsPaintPropertyUpdate(true);

- // Mark all ancestors as having a descendant needing paint property updates.

- // |paintInvalidationParent()| is used to ensure we continue marking across

- // frame boundaries.

LayoutObject* ancestor = paintInvalidationParent();

while (ancestor && !ancestor->descendantNeedsPaintPropertyUpdate()) {

ancestor->m_bitfields.setDescendantNeedsPaintPropertyUpdate(true);