Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1079)

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.h

Issue 2539693002: Early-out from the prepaint tree walk (Closed)
Patch Set: Address chrishtrs comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/FrameView.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/frame/FrameView.h
diff --git a/third_party/WebKit/Source/core/frame/FrameView.h b/third_party/WebKit/Source/core/frame/FrameView.h
index 34ae469618f4a2fcb824dfabe31932249f3645f9..2078addea7ef70a3a23801beb97a13fedcd4c8a7 100644
--- a/third_party/WebKit/Source/core/frame/FrameView.h
+++ b/third_party/WebKit/Source/core/frame/FrameView.h
@@ -727,11 +727,18 @@ class CORE_EXPORT FrameView final
// Paint properties (e.g., m_preTranslation, etc.) are built from the
// FrameView's state (e.g., x(), y(), etc.) as well as inherited context.
- // When these inputs change, setNeedsPaintPropertyUpdate will cause a property
- // tree update during the next document lifecycle update.
- // TODO(pdr): Add additional granularity such as the ability to signal that
- // only a local paint property update is needed.
- void setNeedsPaintPropertyUpdate() { m_needsPaintPropertyUpdate = true; }
+ // When these inputs change, setNeedsPaintPropertyUpdate will cause a paint
+ // property tree update during the next document lifecycle update.
+ // setNeedsPaintPropertyUpdate also sets the owning layout tree as needing a
+ // paint property update.
+ void setNeedsPaintPropertyUpdate();
+#if DCHECK_IS_ON()
+ // Similar to setNeedsPaintPropertyUpdate() but does not set the owning layout
+ // tree as needing a paint property update.
+ void setOnlyThisNeedsPaintPropertyUpdateForTesting() {
+ m_needsPaintPropertyUpdate = true;
+ }
+#endif
void clearNeedsPaintPropertyUpdate() {
DCHECK_EQ(lifecycle().state(), DocumentLifecycle::InPrePaint);
m_needsPaintPropertyUpdate = false;
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/FrameView.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698