Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(766)

Unified Diff: third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp

Issue 2539693002: Early-out from the prepaint tree walk (Closed)
Patch Set: Switch away from typed enums which Windows clang does not like Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp
diff --git a/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp b/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp
index 6ab437c8e08209c143276029ff0081767271a465..05367fefcec32804fe233dd27353e287e4a50fe7 100644
--- a/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp
+++ b/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp
@@ -2929,6 +2929,16 @@ TEST_P(PaintPropertyTreeBuilderTest, DescendantNeedsUpdateAcrossFrames) {
EXPECT_FALSE(divWithTransform->descendantNeedsPaintPropertyUpdate());
EXPECT_FALSE(childLayoutView->descendantNeedsPaintPropertyUpdate());
EXPECT_FALSE(innerDivWithTransform->descendantNeedsPaintPropertyUpdate());
+
+ // A child frame marked as needing a paint property update should not be
+ // skipped if the owning layout tree does not need an update.
+ FrameView* childFrameView = childDocument().view();
+ childFrameView->setNeedsPaintPropertyUpdate();
+ EXPECT_TRUE(document().layoutView()->descendantNeedsPaintPropertyUpdate());
+ frameView->updateAllLifecyclePhases();
+ EXPECT_FALSE(document().layoutView()->descendantNeedsPaintPropertyUpdate());
+ EXPECT_FALSE(frameView->needsPaintPropertyUpdate());
+ EXPECT_FALSE(childFrameView->needsPaintPropertyUpdate());
}
TEST_P(PaintPropertyTreeBuilderTest, UpdatingFrameViewContentClip) {

Powered by Google App Engine
This is Rietveld 408576698