Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Side by Side Diff: third_party/WebKit/Source/core/frame/FrameView.h

Issue 2539693002: Early-out from the prepaint tree walk (Closed)
Patch Set: Do not force subtree updates for all paint invalidation reasons, add todo to track paint offset cha… Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 (C) 1998 Waldo Bastian (bastian@kde.org) 3 (C) 1998 Waldo Bastian (bastian@kde.org)
4 (C) 1998, 1999 Torben Weis (weis@kde.org) 4 (C) 1998, 1999 Torben Weis (weis@kde.org)
5 (C) 1999 Lars Knoll (knoll@kde.org) 5 (C) 1999 Lars Knoll (knoll@kde.org)
6 (C) 1999 Antti Koivisto (koivisto@kde.org) 6 (C) 1999 Antti Koivisto (koivisto@kde.org)
7 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights 7 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights
8 reserved. 8 reserved.
9 9
10 This library is free software; you can redistribute it and/or 10 This library is free software; you can redistribute it and/or
(...skipping 710 matching lines...) Expand 10 before | Expand all | Expand 10 after
721 std::unique_ptr<PropertyTreeState> state) { 721 std::unique_ptr<PropertyTreeState> state) {
722 m_totalPropertyTreeStateForContents = std::move(state); 722 m_totalPropertyTreeStateForContents = std::move(state);
723 } 723 }
724 const PropertyTreeState* totalPropertyTreeStateForContents() const { 724 const PropertyTreeState* totalPropertyTreeStateForContents() const {
725 return m_totalPropertyTreeStateForContents.get(); 725 return m_totalPropertyTreeStateForContents.get();
726 } 726 }
727 727
728 // Paint properties (e.g., m_preTranslation, etc.) are built from the 728 // Paint properties (e.g., m_preTranslation, etc.) are built from the
729 // FrameView's state (e.g., x(), y(), etc.) as well as inherited context. 729 // FrameView's state (e.g., x(), y(), etc.) as well as inherited context.
730 // When these inputs change, setNeedsPaintPropertyUpdate will cause a property 730 // When these inputs change, setNeedsPaintPropertyUpdate will cause a property
731 // tree update during the next document lifecycle update. 731 // tree update during the next document lifecycle update. For subframes,
732 // TODO(pdr): Add additional granularity such as the ability to signal that 732 // the owning LayoutObject is marked as having a descendant needing an update.
733 // only a local paint property update is needed. 733 void setNeedsPaintPropertyUpdate();
734 void setNeedsPaintPropertyUpdate() { m_needsPaintPropertyUpdate = true; } 734 // Same as |setNeedsPaintPropertyUpdate| but does not notify the owning
735 // LayoutObject as having a descendant needing a paint property update.
736 void setNeedsPaintPropertyUpdateWithoutMarkingAncestors() {
737 DCHECK_EQ(lifecycle().state(), DocumentLifecycle::InPrePaint);
738 m_needsPaintPropertyUpdate = true;
739 }
735 void clearNeedsPaintPropertyUpdate() { 740 void clearNeedsPaintPropertyUpdate() {
736 DCHECK_EQ(lifecycle().state(), DocumentLifecycle::InPrePaint); 741 DCHECK_EQ(lifecycle().state(), DocumentLifecycle::InPrePaint);
737 m_needsPaintPropertyUpdate = false; 742 m_needsPaintPropertyUpdate = false;
738 } 743 }
739 bool needsPaintPropertyUpdate() const { return m_needsPaintPropertyUpdate; } 744 bool needsPaintPropertyUpdate() const { return m_needsPaintPropertyUpdate; }
740 // TODO(ojan): Merge this with IntersectionObserver once it lands. 745 // TODO(ojan): Merge this with IntersectionObserver once it lands.
741 IntRect computeVisibleArea(); 746 IntRect computeVisibleArea();
742 747
743 // Viewport size that should be used for viewport units (i.e. 'vh'/'vw'). 748 // Viewport size that should be used for viewport units (i.e. 'vh'/'vw').
744 FloatSize viewportSizeForViewportUnits() const; 749 FloatSize viewportSizeForViewportUnits() const;
(...skipping 407 matching lines...) Expand 10 before | Expand all | Expand 10 after
1152 widget.isFrameView()); 1157 widget.isFrameView());
1153 DEFINE_TYPE_CASTS(FrameView, 1158 DEFINE_TYPE_CASTS(FrameView,
1154 ScrollableArea, 1159 ScrollableArea,
1155 scrollableArea, 1160 scrollableArea,
1156 scrollableArea->isFrameView(), 1161 scrollableArea->isFrameView(),
1157 scrollableArea.isFrameView()); 1162 scrollableArea.isFrameView());
1158 1163
1159 } // namespace blink 1164 } // namespace blink
1160 1165
1161 #endif // FrameView_h 1166 #endif // FrameView_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698