Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Side by Side Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2539693002: Early-out from the prepaint tree walk (Closed)
Patch Set: Address chrishtrs comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Dirk Mueller <mueller@kde.org> 5 * 2000 Dirk Mueller <mueller@kde.org>
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) 7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com)
8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * Copyright (C) 2009 Google Inc. All rights reserved. 9 * Copyright (C) 2009 Google Inc. All rights reserved.
10 * 10 *
(...skipping 1276 matching lines...) Expand 10 before | Expand all | Expand 10 after
1287 void FrameView::invalidatePaintIfNeeded( 1287 void FrameView::invalidatePaintIfNeeded(
1288 const PaintInvalidationState& paintInvalidationState) { 1288 const PaintInvalidationState& paintInvalidationState) {
1289 RELEASE_ASSERT(!layoutViewItem().isNull()); 1289 RELEASE_ASSERT(!layoutViewItem().isNull());
1290 if (!RuntimeEnabledFeatures::rootLayerScrollingEnabled()) 1290 if (!RuntimeEnabledFeatures::rootLayerScrollingEnabled())
1291 invalidatePaintOfScrollControlsIfNeeded(paintInvalidationState); 1291 invalidatePaintOfScrollControlsIfNeeded(paintInvalidationState);
1292 1292
1293 if (m_frame->selection().isCaretBoundsDirty()) 1293 if (m_frame->selection().isCaretBoundsDirty())
1294 m_frame->selection().invalidateCaretRect(); 1294 m_frame->selection().invalidateCaretRect();
1295 } 1295 }
1296 1296
1297 void FrameView::setNeedsPaintPropertyUpdate() {
1298 m_needsPaintPropertyUpdate = true;
1299 if (LayoutObject* owner = frame().ownerLayoutObject())
1300 owner->setNeedsPaintPropertyUpdate();
1301 }
1302
1297 IntRect FrameView::computeVisibleArea() { 1303 IntRect FrameView::computeVisibleArea() {
1298 // Return our clipping bounds in the root frame. 1304 // Return our clipping bounds in the root frame.
1299 IntRect us(frameRect()); 1305 IntRect us(frameRect());
1300 if (FrameView* parent = parentFrameView()) { 1306 if (FrameView* parent = parentFrameView()) {
1301 us = parent->contentsToRootFrame(us); 1307 us = parent->contentsToRootFrame(us);
1302 IntRect parentRect = parent->computeVisibleArea(); 1308 IntRect parentRect = parent->computeVisibleArea();
1303 if (parentRect.isEmpty()) 1309 if (parentRect.isEmpty())
1304 return IntRect(); 1310 return IntRect();
1305 1311
1306 us.intersect(parentRect); 1312 us.intersect(parentRect);
(...skipping 3339 matching lines...) Expand 10 before | Expand all | Expand 10 after
4646 DCHECK(m_frame->isMainFrame()); 4652 DCHECK(m_frame->isMainFrame());
4647 return m_initialViewportSize.width(); 4653 return m_initialViewportSize.width();
4648 } 4654 }
4649 4655
4650 int FrameView::initialViewportHeight() const { 4656 int FrameView::initialViewportHeight() const {
4651 DCHECK(m_frame->isMainFrame()); 4657 DCHECK(m_frame->isMainFrame());
4652 return m_initialViewportSize.height(); 4658 return m_initialViewportSize.height();
4653 } 4659 }
4654 4660
4655 } // namespace blink 4661 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/frame/FrameView.h ('k') | third_party/WebKit/Source/core/layout/LayoutObject.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698