Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 2539683002: Check if cancelled in prepareDataOnMainThread() (Closed)

Created:
4 years ago by hiroshige
Modified:
4 years ago
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check if cancelled in prepareDataOnMainThread() SourceStream::prepareDataOnMainThread() seems to be called after ScriptStreamer::cancel() and thus SourceStream()::cancel() are called. BUG=668611 Committed: https://crrev.com/13c0ca350307abb3ee422161f999594cd4cf7e6c Cr-Commit-Position: refs/heads/master@{#434936}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
hiroshige
PTAL.
4 years ago (2016-11-29 07:47:17 UTC) #5
marja
lgtm
4 years ago (2016-11-29 08:18:56 UTC) #8
kouhei (in TOK)
lgtm
4 years ago (2016-11-29 09:16:51 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2539683002/1
4 years ago (2016-11-29 09:17:16 UTC) #11
haraken
LGTM
4 years ago (2016-11-29 09:22:57 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 09:23:18 UTC) #15
commit-bot: I haz the power
4 years ago (2016-11-29 09:34:43 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/13c0ca350307abb3ee422161f999594cd4cf7e6c
Cr-Commit-Position: refs/heads/master@{#434936}

Powered by Google App Engine
This is Rietveld 408576698