Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 253963002: Web Animations API: Add layout tests for element.animate() keyframes (Closed)

Created:
6 years, 7 months ago by alancutter (OOO until 2018)
Modified:
6 years, 5 months ago
CC:
blink-reviews, shans, rjwright, Mike Lawther (Google), dstockwell, Timothy Loh, darktears, Steve Block, dino_apple.com, Eric Willigers
Visibility:
Public.

Description

Web Animations API: Add layout tests for element.animate() keyframes Adds layout tests for keyframes with the following configurations: - 3 keyframes with and without offsets - Keyframes offsets specified out of order - Explicit null offset value - Shared offset keyframes with overlapping/disjoint properties - Invalid keyframe offsets - Per keyframe easing Fixes flaky test issues due to bug 367903 by running the tests inside requestAnimationFrame(). BUG=367644 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177186

Patch Set 1 #

Patch Set 2 : Split 2 and 3 keyframe tests into separate files #

Patch Set 3 : Remove crash expectations #

Patch Set 4 : Fix unstable timeline flakiness #

Patch Set 5 : More keyframe tests #

Total comments: 2

Patch Set 6 : Added fixme #

Patch Set 7 : Removed RAF hack #

Patch Set 8 : Rebased #

Patch Set 9 : Comments and naming for 3-keyframes-with-offsets #

Total comments: 2

Patch Set 10 : Added comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+364 lines, -19 lines) Patch
A LayoutTests/web-animations-api/w3c/2-keyframes-with-offsets.html View 1 4 5 6 1 chunk +53 lines, -0 lines 0 comments Download
A LayoutTests/web-animations-api/w3c/3-keyframes-with-offsets.html View 1 2 3 4 5 6 7 8 1 chunk +132 lines, -0 lines 0 comments Download
A + LayoutTests/web-animations-api/w3c/eased-keyframes.html View 1 2 3 4 5 6 3 chunks +6 lines, -19 lines 0 comments Download
A LayoutTests/web-animations-api/w3c/ignored-keyframes.html View 1 2 3 4 5 6 7 8 9 1 chunk +81 lines, -0 lines 0 comments Download
A LayoutTests/web-animations-api/w3c/keyframes-with-null-offsets.html View 1 2 3 4 5 6 1 chunk +40 lines, -0 lines 0 comments Download
A LayoutTests/web-animations-api/w3c/same-offset-keyframes.html View 1 2 3 4 5 6 1 chunk +52 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
alancutter (OOO until 2018)
This change depends on https://codereview.chromium.org/252113002/ landing. The test should stop crashing once https://codereview.chromium.org/251463003/ lands.
6 years, 7 months ago (2014-04-29 06:03:55 UTC) #1
alancutter (OOO until 2018)
Updated patch with more keyframe tests, rebased on unsorted offset crash fix, PTAL.
6 years, 7 months ago (2014-04-30 10:58:47 UTC) #2
shans
https://codereview.chromium.org/253963002/diff/80001/LayoutTests/web-animations-api/w3c/resources/keyframes-test.js File LayoutTests/web-animations-api/w3c/resources/keyframes-test.js (right): https://codereview.chromium.org/253963002/diff/80001/LayoutTests/web-animations-api/w3c/resources/keyframes-test.js#newcode32 LayoutTests/web-animations-api/w3c/resources/keyframes-test.js:32: // avoid flaky test results. Considering that we want ...
6 years, 7 months ago (2014-04-30 11:46:27 UTC) #3
alancutter (OOO until 2018)
https://codereview.chromium.org/253963002/diff/80001/LayoutTests/web-animations-api/w3c/resources/keyframes-test.js File LayoutTests/web-animations-api/w3c/resources/keyframes-test.js (right): https://codereview.chromium.org/253963002/diff/80001/LayoutTests/web-animations-api/w3c/resources/keyframes-test.js#newcode32 LayoutTests/web-animations-api/w3c/resources/keyframes-test.js:32: // avoid flaky test results. On 2014/04/30 11:46:27, shans ...
6 years, 7 months ago (2014-05-01 00:05:12 UTC) #4
alancutter (OOO until 2018)
Removed the RAF hack from these W3C tests, PTAL.
6 years, 6 months ago (2014-06-18 06:50:10 UTC) #5
alancutter (OOO until 2018)
On 2014/06/18 06:50:10, alancutter wrote: > Removed the RAF hack from these W3C tests, PTAL. ...
6 years, 5 months ago (2014-06-27 11:01:18 UTC) #6
Eric Willigers
lgtm with nits https://codereview.chromium.org/253963002/diff/150001/LayoutTests/web-animations-api/w3c/ignored-keyframes.html File LayoutTests/web-animations-api/w3c/ignored-keyframes.html (right): https://codereview.chromium.org/253963002/diff/150001/LayoutTests/web-animations-api/w3c/ignored-keyframes.html#newcode13 LayoutTests/web-animations-api/w3c/ignored-keyframes.html:13: var expectations = { Could add ...
6 years, 5 months ago (2014-06-30 00:31:44 UTC) #7
alancutter (OOO until 2018)
On 2014/06/30 00:31:44, Eric Willigers wrote: > lgtm with nits > > https://codereview.chromium.org/253963002/diff/150001/LayoutTests/web-animations-api/w3c/ignored-keyframes.html > File ...
6 years, 5 months ago (2014-06-30 02:57:48 UTC) #8
alancutter (OOO until 2018)
The CQ bit was checked by alancutter@chromium.org
6 years, 5 months ago (2014-06-30 02:59:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alancutter@chromium.org/253963002/170001
6 years, 5 months ago (2014-06-30 02:59:46 UTC) #10
commit-bot: I haz the power
6 years, 5 months ago (2014-06-30 04:02:02 UTC) #11
Message was sent while issue was closed.
Change committed as 177186

Powered by Google App Engine
This is Rietveld 408576698