Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2539593002: Fix blank names issue for navigator.usb.requestDevice (Closed)

Created:
4 years ago by juncai
Modified:
4 years ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix blank names issue for navigator.usb.requestDevice Sometimes UsbDevice::product_string() returns empty string, and the current WebUSB chooser uses it as the device name to be displayed. This CL fixes the blank name issue by displaying, in decreasing order of preference: 1. UsbDevice::product_string() 2. UsbIds::GetProductName() 3. "Unknown device from " + UsbIds::GetVendorName() 4. "Unknown device [$VID:$PID]" BUG=665599 Committed: https://crrev.com/06198969e3c76b4999cbdf1a474bb4f94ee275cd Cr-Commit-Position: refs/heads/master@{#435019}

Patch Set 1 : fix blank names issue for navigator.usb.requestDevice #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -2 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/usb/usb_chooser_controller.cc View 5 chunks +29 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
juncai
Please take a look.
4 years ago (2016-11-28 23:10:15 UTC) #4
Reilly Grant (use Gerrit)
lgtm
4 years ago (2016-11-29 16:57:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2539593002/1
4 years ago (2016-11-29 17:16:57 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 17:24:02 UTC) #11
commit-bot: I haz the power
4 years ago (2016-11-29 17:25:59 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/06198969e3c76b4999cbdf1a474bb4f94ee275cd
Cr-Commit-Position: refs/heads/master@{#435019}

Powered by Google App Engine
This is Rietveld 408576698