Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 2539583003: [Android] Fix NullPointerException crash in SpellCheckerSessionBridge. (Closed)

Created:
4 years ago by timvolodine
Modified:
4 years ago
Reviewers:
Tobias Sargeant
CC:
chromium-reviews, groby+spellwatch_chromium.org, rlp+watch_chromium.org, rouslan+spell_chromium.org, timvolodine, agrieve+watch_chromium.org
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

[Android] Fix NullPointerException crash in SpellCheckerSessionBridge. Merge to M55 (branch 2883) Add a check for potential null results when the spellchecking service returns in onGetSentenceSuggestions. Haven't tested, reproduced or investigated the cause of this (i.e. nulls in results) but seems the right approach to avoid crashes in the first place, see crbug.com/651458 for more details. BUG=651458, 583616, 629609 TBR=tobiasjs@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2413873003 Cr-Commit-Position: refs/heads/master@{#425004} (cherry picked from commit f16e0045b2dd3e399e14e5a44db1d8b1b18d46e9)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M components/spellcheck/browser/android/java/src/org/chromium/components/spellcheck/SpellCheckerSessionBridge.java View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2539583003/1
4 years ago (2016-11-29 19:34:26 UTC) #4
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
4 years ago (2016-11-29 19:34:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2539583003/1
4 years ago (2016-11-29 19:35:52 UTC) #9
commit-bot: I haz the power
4 years ago (2016-11-29 19:43:50 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698