Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 2539573002: Update milestone for EME non-standard functionality (Closed)

Created:
4 years ago by jrummell
Modified:
4 years ago
Reviewers:
xhwang, ddorwin, foolip
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update milestone for EME non-standard functionality Moving milestone to M58. BUG=605661 TEST=messages logged with EME layout tests Committed: https://crrev.com/c4b5bb4969a525126bb416aea5407f413abf0d0c Cr-Commit-Position: refs/heads/master@{#434852}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/frame/Deprecation.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (8 generated)
jrummell
PTAL.
4 years ago (2016-11-28 21:46:59 UTC) #2
ddorwin
lgtm
4 years ago (2016-11-28 21:50:28 UTC) #3
xhwang
lgtm
4 years ago (2016-11-28 21:53:41 UTC) #4
foolip
lgtm, but presumably test expectations need updating.
4 years ago (2016-11-28 23:35:11 UTC) #5
foolip
On 2016/11/28 23:35:11, foolip wrote: > lgtm, but presumably test expectations need updating. Also, I ...
4 years ago (2016-11-28 23:35:33 UTC) #7
jrummell
> lgtm, but presumably test expectations need updating. There aren't any test expectations for the ...
4 years ago (2016-11-29 00:41:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2539573002/1
4 years ago (2016-11-29 02:28:39 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 02:58:55 UTC) #15
commit-bot: I haz the power
4 years ago (2016-11-29 03:04:18 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c4b5bb4969a525126bb416aea5407f413abf0d0c
Cr-Commit-Position: refs/heads/master@{#434852}

Powered by Google App Engine
This is Rietveld 408576698