|
|
Chromium Code Reviews|
Created:
4 years ago by Bence Modified:
4 years ago Reviewers:
Ryan Hamilton CC:
chromium-reviews, cbentzel+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMinor cleanup in SpdySession.
* Remove out-of-date comment in OnStreamEnd(); inline |buffer|.
* Remove non-HTTP/2 code path in OnStreamPadding().
Committed: https://crrev.com/13304a1d415dc258fb3058aa9236df4555d5800d
Cr-Commit-Position: refs/heads/master@{#434871}
Patch Set 1 #
Total comments: 1
Patch Set 2 : Fix rebase oversight. #Messages
Total messages: 17 (12 generated)
The CQ bit was checked by bnc@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_cronet on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
The CQ bit was checked by bnc@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
bnc@chromium.org changed reviewers: + rch@chromium.org
Ryan: PTAL. Thank you. https://codereview.chromium.org/2539563002/diff/1/net/spdy/spdy_session.cc File net/spdy/spdy_session.cc (left): https://codereview.chromium.org/2539563002/diff/1/net/spdy/spdy_session.cc#ol... net/spdy/spdy_session.cc:2559: stream->AddRawReceivedBytes(last_compressed_frame_len_); Return around line 2479 makes this branch dead.
The CQ bit was checked by rch@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 10002, "attempt_start_ts": 1480390321660660,
"parent_rev": "e8dfc8466859034d19653c4e75fdeef2f9535c6f", "commit_rev":
"f2af0567b2f3679f048d17ffa36bf35176e2bdf6"}
Message was sent while issue was closed.
Committed patchset #2 (id:10002)
Message was sent while issue was closed.
Description was changed from ========== Minor cleanup in SpdySession. * Remove out-of-date comment in OnStreamEnd(); inline |buffer|. * Remove non-HTTP/2 code path in OnStreamPadding(). ========== to ========== Minor cleanup in SpdySession. * Remove out-of-date comment in OnStreamEnd(); inline |buffer|. * Remove non-HTTP/2 code path in OnStreamPadding(). Committed: https://crrev.com/13304a1d415dc258fb3058aa9236df4555d5800d Cr-Commit-Position: refs/heads/master@{#434871} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/13304a1d415dc258fb3058aa9236df4555d5800d Cr-Commit-Position: refs/heads/master@{#434871} |
