Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 2539563002: Minor cleanup in SpdySession. (Closed)

Created:
4 years ago by Bence
Modified:
4 years ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Minor cleanup in SpdySession. * Remove out-of-date comment in OnStreamEnd(); inline |buffer|. * Remove non-HTTP/2 code path in OnStreamPadding(). Committed: https://crrev.com/13304a1d415dc258fb3058aa9236df4555d5800d Cr-Commit-Position: refs/heads/master@{#434871}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix rebase oversight. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -16 lines) Patch
M net/spdy/spdy_session.cc View 1 3 chunks +3 lines, -16 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
Bence
Ryan: PTAL. Thank you. https://codereview.chromium.org/2539563002/diff/1/net/spdy/spdy_session.cc File net/spdy/spdy_session.cc (left): https://codereview.chromium.org/2539563002/diff/1/net/spdy/spdy_session.cc#oldcode2559 net/spdy/spdy_session.cc:2559: stream->AddRawReceivedBytes(last_compressed_frame_len_); Return around line 2479 ...
4 years ago (2016-11-29 00:28:44 UTC) #10
Ryan Hamilton
lgtm
4 years ago (2016-11-29 03:32:02 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2539563002/10002
4 years ago (2016-11-29 03:32:34 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:10002)
4 years ago (2016-11-29 03:37:47 UTC) #15
commit-bot: I haz the power
4 years ago (2016-11-29 03:43:24 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/13304a1d415dc258fb3058aa9236df4555d5800d
Cr-Commit-Position: refs/heads/master@{#434871}

Powered by Google App Engine
This is Rietveld 408576698