Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: adb/contrib/high.py

Issue 2539543009: python-adb: Fix bug with shell command out. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: adb/contrib/high.py
diff --git a/adb/contrib/high.py b/adb/contrib/high.py
index 645d7c238c7d06afa7024e1363e93d822e2cf430..f1946d7fad1914ea99c240b2e4f96710983efbd9 100644
--- a/adb/contrib/high.py
+++ b/adb/contrib/high.py
@@ -144,7 +144,7 @@ def _InitCache(device):
# due to SELinux permission errors. Try again by executing su via shell.
if not has_su:
out, exit_code = device.Shell('/system/xbin/su root whoami')
- if not exit_code and out.strip() == 'root':
+ if not exit_code and out and out.strip() == 'root':
has_su = True
available_governors = KNOWN_CPU_SCALING_GOVERNOR_VALUES
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698