Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2539543007:
macOS: Fix <select> popup menu position in RTL. (Closed)
DescriptionmacOS: Fix <select> popup menu position in RTL.
Calls setUserInterfaceLayoutDirection:NSUserInterfaceLayoutDirectionRightToLeft
for NSMenu if it's available.
This fixes the issue only on macOS 10.11+.
BUG=339766
Committed: https://crrev.com/273a3b74ee2e4c676bcc617c5d4acd3005187b7f
Cr-Commit-Position: refs/heads/master@{#435481}
Patch Set 1 #
Total comments: 2
Patch Set 2 : No respondoToSelector for NSPopUpButtonCell #Messages
Total messages: 21 (14 generated)
The CQ bit was checked by tkent@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
tkent@chromium.org changed reviewers: + avi@chromium.org
avi@, would you review this please?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
non-owner LGTM, I'm no expert on this area, but look correct after looking at this for a few hours. The corresponding WebKit fix: https://trac.webkit.org/changeset/200268/trunk/Source/WebKit/mac/WebCoreSuppo...
LGTM with fix. https://codereview.chromium.org/2539543007/diff/1/content/browser/renderer_ho... File content/browser/renderer_host/webmenurunner_mac.mm (right): https://codereview.chromium.org/2539543007/diff/1/content/browser/renderer_ho... content/browser/renderer_host/webmenurunner_mac.mm:125: if ([cell respondsToSelector:sel]) { NSCell has supported this property since 10.6, so it's safe to pull the if() and always do the call. (I think I put this -respondsToSelector: guard back when we supported 10.5.)
The CQ bit was checked by tkent@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
tkent@chromium.org changed reviewers: + kojii@chromium.org
https://codereview.chromium.org/2539543007/diff/1/content/browser/renderer_ho... File content/browser/renderer_host/webmenurunner_mac.mm (right): https://codereview.chromium.org/2539543007/diff/1/content/browser/renderer_ho... content/browser/renderer_host/webmenurunner_mac.mm:125: if ([cell respondsToSelector:sel]) { On 2016/11/30 at 17:25:04, Avi wrote: > NSCell has supported this property since 10.6, so it's safe to pull the if() and always do the call. (I think I put this -respondsToSelector: guard back when we supported 10.5.) Done.
The CQ bit was checked by tkent@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org, kojii@chromium.org Link to the patchset: https://codereview.chromium.org/2539543007/#ps20001 (title: "No respondoToSelector for NSPopUpButtonCell")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480549443565200,
"parent_rev": "c007f0aa92edcf67ead57e951ea5ef956e93a5a4", "commit_rev":
"644e52a589b68e6f998f6e80a52130af20d0e14a"}
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== macOS: Fix <select> popup menu position in RTL. Calls setUserInterfaceLayoutDirection:NSUserInterfaceLayoutDirectionRightToLeft for NSMenu if it's available. This fixes the issue only on macOS 10.11+. BUG=339766 ========== to ========== macOS: Fix <select> popup menu position in RTL. Calls setUserInterfaceLayoutDirection:NSUserInterfaceLayoutDirectionRightToLeft for NSMenu if it's available. This fixes the issue only on macOS 10.11+. BUG=339766 Committed: https://crrev.com/273a3b74ee2e4c676bcc617c5d4acd3005187b7f Cr-Commit-Position: refs/heads/master@{#435481} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/273a3b74ee2e4c676bcc617c5d4acd3005187b7f Cr-Commit-Position: refs/heads/master@{#435481} |
