Chromium Code Reviews| Index: test/cctest/test-assembler-arm.cc |
| diff --git a/test/cctest/test-assembler-arm.cc b/test/cctest/test-assembler-arm.cc |
| index ac6dc9c5d02bf063dc6beb3fd471c2ffac1391b4..26aa5795db99a69b036ee84c7b27bef1ccb52b40 100644 |
| --- a/test/cctest/test-assembler-arm.cc |
| +++ b/test/cctest/test-assembler-arm.cc |
| @@ -2919,42 +2919,52 @@ TEST(vswp) { |
| Assembler assm(isolate, NULL, 0); |
| typedef struct { |
| - double result0; |
| - double result1; |
| - double result2; |
| - double result3; |
| - double result4; |
| - double result5; |
| - double result6; |
| - double result7; |
| + uint64_t result0; |
| + uint64_t result1; |
| + uint64_t result2; |
| + uint64_t result3; |
| + uint64_t result4; |
| + uint64_t result5; |
| + uint64_t result6; |
| + uint64_t result7; |
| } T; |
| T t; |
| - __ vmov(d0, 1.0); |
| - __ vmov(d1, -1.0); |
| + __ stm(db_w, sp, r4.bit() | r5.bit() | r6.bit() | r7.bit() | lr.bit()); |
| + |
| + uint64_t one = bit_cast<uint64_t>(1.0); |
| + __ mov(r5, Operand(one >> 32)); |
| + __ mov(r4, Operand(one & 0xffffffff)); |
| + uint64_t minus_one = bit_cast<uint64_t>(-1.0); |
| + __ mov(r7, Operand(minus_one >> 32)); |
| + __ mov(r6, Operand(minus_one & 0xffffffff)); |
| + |
| + __ vmov(d0, r4, r5); // d0 = 1.0 |
| + __ vmov(d1, r6, r7); // d1 = -1.0 |
| __ vswp(d0, d1); |
| __ vstr(d0, r0, offsetof(T, result0)); |
| __ vstr(d1, r0, offsetof(T, result1)); |
| if (CpuFeatures::IsSupported(VFP32DREGS)) { |
| - __ vmov(d30, 1.0); |
| - __ vmov(d31, -1.0); |
| + __ vmov(d30, r4, r5); // d30 = 1.0 |
| + __ vmov(d31, r6, r7); // d31 = -1.0 |
| __ vswp(d30, d31); |
| __ vstr(d30, r0, offsetof(T, result2)); |
| __ vstr(d31, r0, offsetof(T, result3)); |
| } |
| // q-register swap. |
| - __ vmov(d8, 1.0); |
| - __ vmov(d9, 2.0); |
| - __ vmov(d10, 3.0); |
| - __ vmov(d11, 4.0); |
| + __ vmov(d8, r4, r5); |
| + __ vmov(d9, r4, r5); // q4 = [1.0, 1.0] |
| + __ vmov(d10, r6, r7); |
| + __ vmov(d11, r6, r7); // q5 = [-1.0, -1.0] |
| __ vswp(q4, q5); |
| __ vstr(d8, r0, offsetof(T, result4)); |
| __ vstr(d9, r0, offsetof(T, result5)); |
| __ vstr(d10, r0, offsetof(T, result6)); |
| __ vstr(d11, r0, offsetof(T, result7)); |
| + __ ldm(ia_w, sp, r4.bit() | r5.bit() | r6.bit() | r7.bit() | pc.bit()); |
| __ bx(lr); |
| CodeDesc desc; |
| @@ -2968,16 +2978,16 @@ TEST(vswp) { |
| F3 f = FUNCTION_CAST<F3>(code->entry()); |
| Object* dummy = CALL_GENERATED_CODE(isolate, f, &t, 0, 0, 0, 0); |
| USE(dummy); |
| - CHECK_EQ(-1.0, t.result0); |
| - CHECK_EQ(1.0, t.result1); |
| + CHECK_EQ(minus_one, t.result0); |
| + CHECK_EQ(one, t.result1); |
| if (CpuFeatures::IsSupported(VFP32DREGS)) { |
| - CHECK_EQ(-1.0, t.result2); |
| - CHECK_EQ(1.0, t.result3); |
| + CHECK_EQ(minus_one, t.result2); |
| + CHECK_EQ(one, t.result3); |
| } |
| - CHECK_EQ(3.0, t.result4); |
| - CHECK_EQ(4.0, t.result5); |
| - CHECK_EQ(1.0, t.result6); |
| - CHECK_EQ(2.0, t.result7); |
| + CHECK_EQ(minus_one, t.result4); |
| + CHECK_EQ(minus_one, t.result5); |
| + CHECK_EQ(one, t.result6); |
| + CHECK_EQ(one, t.result7); |
|
jbramley
2016/11/30 17:38:05
I wonder if it's useful to use other values (like
bbudge
2016/11/30 19:15:18
Yes, good point. I'll put a non-FP test pattern in
|
| } |
| TEST(regress4292_b) { |