Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(855)

Unified Diff: third_party/WebKit/Source/modules/compositorworker/AnimationWorkletThreadTest.cpp

Issue 2539443004: Worker: Move ParentFrameTaskRunners from WorkerReportingProxy to ObjectProxy (Closed)
Patch Set: rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/compositorworker/AnimationWorkletThreadTest.cpp
diff --git a/third_party/WebKit/Source/modules/compositorworker/AnimationWorkletThreadTest.cpp b/third_party/WebKit/Source/modules/compositorworker/AnimationWorkletThreadTest.cpp
index f52cac691c487cbf8cdd53a46cbd660205a46265..c2853a7996b98e80d2fcfe7ffd634c935ef26308 100644
--- a/third_party/WebKit/Source/modules/compositorworker/AnimationWorkletThreadTest.cpp
+++ b/third_party/WebKit/Source/modules/compositorworker/AnimationWorkletThreadTest.cpp
@@ -48,20 +48,13 @@ class TestAnimationWorkletReportingProxy : public WorkerReportingProxy {
const String& message,
SourceLocation*) override {}
void postMessageToPageInspector(const String&) override {}
- ParentFrameTaskRunners* getParentFrameTaskRunners() override {
- return m_parentFrameTaskRunners.get();
- }
-
void didEvaluateWorkerScript(bool success) override {}
void didCloseWorkerGlobalScope() override {}
void willDestroyWorkerGlobalScope() override {}
void didTerminateWorkerThread() override {}
private:
- TestAnimationWorkletReportingProxy()
- : m_parentFrameTaskRunners(ParentFrameTaskRunners::create(nullptr)) {}
-
- Persistent<ParentFrameTaskRunners> m_parentFrameTaskRunners;
+ TestAnimationWorkletReportingProxy() {}
};
class AnimationWorkletTestPlatform : public TestingPlatformSupport {
@@ -97,7 +90,8 @@ class AnimationWorkletThreadTest : public ::testing::Test {
std::unique_ptr<AnimationWorkletThread> createAnimationWorkletThread() {
std::unique_ptr<AnimationWorkletThread> thread =
- AnimationWorkletThread::create(nullptr, *m_reportingProxy);
+ AnimationWorkletThread::create(nullptr, *m_reportingProxy,
+ ParentFrameTaskRunners::create(nullptr));
thread->start(WorkerThreadStartupData::create(
KURL(ParsedURLString, "http://fake.url/"), "fake user agent", "",
nullptr, DontPauseWorkerGlobalScopeOnStart, nullptr, "",

Powered by Google App Engine
This is Rietveld 408576698