Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: third_party/WebKit/Source/core/workers/ThreadedWorkletTest.cpp

Issue 2539443004: Worker: Move ParentFrameTaskRunners from WorkerReportingProxy to ObjectProxy (Closed)
Patch Set: rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/workers/ThreadedWorkletTest.cpp
diff --git a/third_party/WebKit/Source/core/workers/ThreadedWorkletTest.cpp b/third_party/WebKit/Source/core/workers/ThreadedWorkletTest.cpp
index a0a16925584b8bf3bd2d34e3d78c7ed94acd86fc..ba6daf99d244461fdb7a096972c5813a9ba0139f 100644
--- a/third_party/WebKit/Source/core/workers/ThreadedWorkletTest.cpp
+++ b/third_party/WebKit/Source/core/workers/ThreadedWorkletTest.cpp
@@ -23,9 +23,11 @@ class ThreadedWorkletThreadForTest : public WorkerThread {
public:
ThreadedWorkletThreadForTest(
WorkerLoaderProxyProvider* workerLoaderProxyProvider,
- WorkerReportingProxy& workerReportingProxy)
+ WorkerReportingProxy& workerReportingProxy,
+ ParentFrameTaskRunners* parentFrameTaskRunners)
: WorkerThread(WorkerLoaderProxy::create(workerLoaderProxyProvider),
- workerReportingProxy) {}
+ workerReportingProxy,
+ parentFrameTaskRunners) {}
~ThreadedWorkletThreadForTest() override{};
WorkerBackingThread& workerBackingThread() override {
@@ -63,8 +65,7 @@ class ThreadedWorkletThreadForTest : public WorkerThread {
void countFeature(UseCounter::Feature feature) {
EXPECT_TRUE(isCurrentThread());
globalScope()->countFeature(feature);
- workerReportingProxy()
- .getParentFrameTaskRunners()
+ getParentFrameTaskRunners()
->get(TaskType::UnspecedTimer)
->postTask(BLINK_FROM_HERE, crossThreadBind(&testing::exitRunLoop));
}
@@ -80,8 +81,7 @@ class ThreadedWorkletThreadForTest : public WorkerThread {
String consoleMessage = consoleMessageStorage()->at(0)->message();
EXPECT_TRUE(consoleMessage.contains("deprecated"));
- workerReportingProxy()
- .getParentFrameTaskRunners()
+ getParentFrameTaskRunners()
->get(TaskType::UnspecedTimer)
->postTask(BLINK_FROM_HERE, crossThreadBind(&testing::exitRunLoop));
}
@@ -95,7 +95,8 @@ class ThreadedWorkletMessagingProxyForTest
m_mockWorkerLoaderProxyProvider =
WTF::makeUnique<MockWorkerLoaderProxyProvider>();
m_workerThread = WTF::makeUnique<ThreadedWorkletThreadForTest>(
- m_mockWorkerLoaderProxyProvider.get(), workletObjectProxy());
+ m_mockWorkerLoaderProxyProvider.get(), workletObjectProxy(),
+ getParentFrameTaskRunners());
ThreadedWorkletThreadForTest::ensureSharedBackingThread();
}

Powered by Google App Engine
This is Rietveld 408576698