Add UMA to track the duration of CheckFrambufferValid

Add UMA to track the duration of CheckFrambufferValid

We are getting a lot of GPU watchdog hangs in this function. Add an UMA
to confirm that this function is long-running, and that we don't have an
issue with the watchdog.

Also removes ProgramManager UMAs which were added for a similar bug that
has now been resolved.

BUG=662802
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/f4eade7013d8327ad0bf168dc82b7e481dd33975
Cr-Commit-Position: refs/heads/master@{#435415}

[ericrk, 2016-11-28 22:31:12]

Description was changed from

==========
Add UMA to track the duration of CheckFrambufferValid

We are getting a lot of GPU watchdog hangs in this function. Add an UMA
to confirm that this function is long-running, and that we don't have an
issue with the watchdog.

Also removes ProgramManager UMAs which were added for a similar bug that
has now been resolved.

BUG=662802
==========

to

==========
Add UMA to track the duration of CheckFrambufferValid

We are getting a lot of GPU watchdog hangs in this function. Add an UMA
to confirm that this function is long-running, and that we don't have an
issue with the watchdog.

Also removes ProgramManager UMAs which were added for a similar bug that
has now been resolved.

BUG=662802
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[ericrk, 2016-11-28 22:33:01]

ericrk@chromium.org changed reviewers:
+ isherman@chromium.org, zmo@chromium.org

[Ilya Sherman, 2016-11-29 03:07:34]

metrics LGTM % a comment:

https://codereview.chromium.org/2539443003/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/2539443003/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:19330: -<histogram
name="GPU.DestroyProgramManagerPrograms.Elapsed" units="ms">
Please mark these histograms as <obsolete> rather than removing their metadata.

[ericrk, 2016-11-29 21:44:16]

https://codereview.chromium.org/2539443003/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/2539443003/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:19330: -<histogram
name="GPU.DestroyProgramManagerPrograms.Elapsed" units="ms">
On 2016/11/29 03:07:33, Ilya Sherman wrote:
> Please mark these histograms as <obsolete> rather than removing their
metadata.

Ah, thanks! done.

[ericrk, 2016-11-29 21:44:23]

The CQ bit was checked by ericrk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-29 21:45:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ericrk, 2016-11-29 23:43:14]

Description was changed from

==========
Add UMA to track the duration of CheckFrambufferValid

We are getting a lot of GPU watchdog hangs in this function. Add an UMA
to confirm that this function is long-running, and that we don't have an
issue with the watchdog.

Also removes ProgramManager UMAs which were added for a similar bug that
has now been resolved.

BUG=662802
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Add UMA to track the duration of CheckFrambufferValid

We are getting a lot of GPU watchdog hangs in this function. Add an UMA
to confirm that this function is long-running, and that we don't have an
issue with the watchdog.

Also removes ProgramManager UMAs which were added for a similar bug that
has now been resolved.

BUG=662802
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[ericrk, 2016-11-29 23:43:14]

ericrk@chromium.org changed reviewers:
- zmo@chromium.org

[ericrk, 2016-11-29 23:43:35]

ericrk@chromium.org changed reviewers:
+ kbr@chromium.org

[commit-bot: I haz the power, 2016-11-29 23:47:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 23:47:57]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_optional_gpu_tests_rel on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[Ken Russell (switch to Gerrit), 2016-11-30 01:19:19]

lgtm

[ericrk, 2016-11-30 21:02:58]

The CQ bit was checked by ericrk@chromium.org

[ericrk, 2016-11-30 21:02:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
isherman@chromium.org
Link to the patchset: https://codereview.chromium.org/2539443003/#ps20001
(title: "obsolete rather than remove histograms")

[commit-bot: I haz the power, 2016-11-30 21:03:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 21:09:07]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480539778151230,
"parent_rev": "b2256f86a7aeaa33b84b5ebe7c018999205891cc", "commit_rev":
"3df03753aeefb45c8f85baa02cc2ee2c607b2974"}

[commit-bot: I haz the power, 2016-11-30 21:09:38]

Description was changed from

==========
Add UMA to track the duration of CheckFrambufferValid

We are getting a lot of GPU watchdog hangs in this function. Add an UMA
to confirm that this function is long-running, and that we don't have an
issue with the watchdog.

Also removes ProgramManager UMAs which were added for a similar bug that
has now been resolved.

BUG=662802
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Add UMA to track the duration of CheckFrambufferValid

We are getting a lot of GPU watchdog hangs in this function. Add an UMA
to confirm that this function is long-running, and that we don't have an
issue with the watchdog.

Also removes ProgramManager UMAs which were added for a similar bug that
has now been resolved.

BUG=662802
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-11-30 21:09:39]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-30 21:12:40]

Description was changed from

==========
Add UMA to track the duration of CheckFrambufferValid

We are getting a lot of GPU watchdog hangs in this function. Add an UMA
to confirm that this function is long-running, and that we don't have an
issue with the watchdog.

Also removes ProgramManager UMAs which were added for a similar bug that
has now been resolved.

BUG=662802
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Add UMA to track the duration of CheckFrambufferValid

We are getting a lot of GPU watchdog hangs in this function. Add an UMA
to confirm that this function is long-running, and that we don't have an
issue with the watchdog.

Also removes ProgramManager UMAs which were added for a similar bug that
has now been resolved.

BUG=662802
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/f4eade7013d8327ad0bf168dc82b7e481dd33975
Cr-Commit-Position: refs/heads/master@{#435415}
==========

[commit-bot: I haz the power, 2016-11-30 21:12:41]

Patchset 2 (id:??) landed as
https://crrev.com/f4eade7013d8327ad0bf168dc82b7e481dd33975
Cr-Commit-Position: refs/heads/master@{#435415}