Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 2539403002: [X87] [crankshaft] Always use Label:kFar as lable dist in DoWrapReceiver() for debug mode. (Closed)

Created:
4 years ago by zhengxing.li
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[X87] [crankshaft] Always use Label:kFar as lable dist in DoWrapReceiver() for debug mode. Currently In LCodeGen::DoWrapReceiver(), the x87 jitted code's size for debug mode between label's define and bind exceeds 128 bytes whether FLAG_deopt_every_n_times is set or not. So always use Label:kFar as label distance in LCodeGen::DoWrapReceiver() for debug mode. This CL also unify the label's distance value to avoid potential bugs caused by unconsistent distance value usage for the same label when DeoptEveryNTimes() return true. BUG= Committed: https://crrev.com/0d0d834e6719738e0b2473b838518fe15e79bb1c Cr-Commit-Position: refs/heads/master@{#41419}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -4 lines) Patch
M src/crankshaft/x87/lithium-codegen-x87.cc View 3 chunks +13 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
zhengxing.li
PTAL, thanks!
4 years ago (2016-12-01 09:56:59 UTC) #2
Benedikt Meurer
lgtm
4 years ago (2016-12-01 09:57:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2539403002/1
4 years ago (2016-12-01 10:21:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-01 10:47:59 UTC) #7
commit-bot: I haz the power
4 years ago (2016-12-01 10:48:39 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0d0d834e6719738e0b2473b838518fe15e79bb1c
Cr-Commit-Position: refs/heads/master@{#41419}

Powered by Google App Engine
This is Rietveld 408576698