Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2539343003: [ios] Adds authentication, popup_menu and side_swipe resources (Closed)

Created:
4 years ago by sczs1
Modified:
4 years ago
CC:
chromium-reviews, pkl (ping after 24h if needed), sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Adds authentication, popup_menu and side_swipe resources BUG=666732 Committed: https://crrev.com/2448ab1e9899e2cb57494d4e624ff52d4d5722ef Cr-Commit-Position: refs/heads/master@{#435962}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -0 lines) Patch
A ios/chrome/browser/ui/authentication/BUILD.gn View 1 chunk +14 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/authentication/resources/signin_confirmation_more.png View Binary file 0 comments Download
A ios/chrome/browser/ui/authentication/resources/signin_confirmation_more@2x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/authentication/resources/signin_confirmation_more@3x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/popup_menu/BUILD.gn View 1 chunk +14 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/popup_menu/resources/popup_background.png View Binary file 0 comments Download
A ios/chrome/browser/ui/popup_menu/resources/popup_background@2x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/popup_menu/resources/popup_background@3x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/side_swipe/BUILD.gn View 1 chunk +17 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/side_swipe/resources/side_swipe_navigation_back.png View Binary file 0 comments Download
A ios/chrome/browser/ui/side_swipe/resources/side_swipe_navigation_back@2x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/side_swipe/resources/side_swipe_navigation_back@3x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/side_swipe/resources/side_swipe_navigation_content_shadow.png View Binary file 0 comments Download
A ios/chrome/browser/ui/side_swipe/resources/side_swipe_navigation_content_shadow@2x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/side_swipe/resources/side_swipe_navigation_content_shadow@3x.png View Binary file 0 comments Download

Messages

Total messages: 19 (10 generated)
sczs1
PTAL and send to CQ if lgty
4 years ago (2016-12-02 02:16:35 UTC) #3
rohitrao (ping after 24h)
lg, @sdefresne are you happy with moving files this way?
4 years ago (2016-12-02 02:22:58 UTC) #6
rohitrao (ping after 24h)
Actually, looking at the diff in the email, I see lots of ". Is your ...
4 years ago (2016-12-02 03:06:24 UTC) #7
sczs1
On 2016/12/02 03:06:24, rohitrao wrote: > Actually, looking at the diff in the email, I ...
4 years ago (2016-12-02 03:34:44 UTC) #10
rohitrao (ping after 24h)
lgtm
4 years ago (2016-12-02 17:16:14 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2539343003/1
4 years ago (2016-12-02 17:16:34 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-02 17:21:16 UTC) #16
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2448ab1e9899e2cb57494d4e624ff52d4d5722ef Cr-Commit-Position: refs/heads/master@{#435962}
4 years ago (2016-12-02 17:24:45 UTC) #18
sdefresne
4 years ago (2016-12-05 14:58:33 UTC) #19
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698