Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1391)

Issue 2539333003: Fix crash when calling convertToBlob on an OffscreenCanvas with no pixels (Closed)

Created:
4 years ago by Justin Novosad
Modified:
4 years ago
Reviewers:
xidachen
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix crash when calling convertToBlob on an OffscreenCanvas with no pixels BUG=669392 Committed: https://crrev.com/1307b3fee54e09311014071340c0822752aee55c Cr-Commit-Position: refs/heads/master@{#435729}

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove tab characters #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-zero-size-readback.html View 1 1 chunk +64 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (10 generated)
Justin Novosad
PTAL
4 years ago (2016-12-01 19:31:48 UTC) #3
xidachen
lgtm https://codereview.chromium.org/2539333003/diff/1/third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-zero-size-readback.html File third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-zero-size-readback.html (right): https://codereview.chromium.org/2539333003/diff/1/third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-zero-size-readback.html#newcode57 third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-zero-size-readback.html:57: var imgdata = ctx.getImageData(0, 0, 1, 1); nits: ...
4 years ago (2016-12-01 19:46:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2539333003/1
4 years ago (2016-12-01 20:08:03 UTC) #8
Justin Novosad
https://codereview.chromium.org/2539333003/diff/1/third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-zero-size-readback.html File third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-zero-size-readback.html (right): https://codereview.chromium.org/2539333003/diff/1/third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-zero-size-readback.html#newcode57 third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-zero-size-readback.html:57: var imgdata = ctx.getImageData(0, 0, 1, 1); On 2016/12/01 ...
4 years ago (2016-12-01 20:09:39 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2539333003/20001
4 years ago (2016-12-01 20:12:34 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-01 21:56:10 UTC) #15
commit-bot: I haz the power
4 years ago (2016-12-01 21:58:02 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1307b3fee54e09311014071340c0822752aee55c
Cr-Commit-Position: refs/heads/master@{#435729}

Powered by Google App Engine
This is Rietveld 408576698