PerformanceMonitor: do not maintain a vector of frames in the monitor, single ExecutionContext memb…

third_party/WebKit/Source/core/timing/PerformanceTest.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/timing/Performance.h"
 
 #include "core/frame/PerformanceMonitor.h"
 #include "core/testing/DummyPageHolder.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
@@ skipping 22 matching lines @@
     m_performance->m_observerFilterOptions |= PerformanceEntry::LongTask;
   }
 
   void removeLongTaskObserver() {
     // simulate with filter options.
     m_performance->m_observerFilterOptions = PerformanceEntry::Invalid;
   }
 
   LocalFrame* frame() const { return m_pageHolder->document().frame(); }
 
+  Document* document() const { return &m_pageHolder->document(); }
+
   LocalFrame* anotherFrame() const {
     return m_anotherPageHolder->document().frame();
   }
 
-  String sanitizedAttribution(const HeapHashSet<Member<Frame>>& frames,
+  Document* anotherDocument() const { return &m_anotherPageHolder->document(); }
+
+  String sanitizedAttribution(ExecutionContext* context,
+                              bool hasMultipleContexts,
                               Frame* observerFrame) {
-    return Performance::sanitizedAttribution(frames, observerFrame).first;
+    return Performance::sanitizedAttribution(context, hasMultipleContexts,
+                                             observerFrame)
+        .first;
   }
 
   Persistent<Performance> m_performance;
   std::unique_ptr<DummyPageHolder> m_pageHolder;
   std::unique_ptr<DummyPageHolder> m_anotherPageHolder;
 };
 
 TEST_F(PerformanceTest, LongTaskObserverInstrumentation) {
   m_performance->updateLongTaskInstrumentation();
   EXPECT_FALSE(observingLongTasks());
 
   // Adding LongTask observer (with filer option) enables instrumentation.
   addLongTaskObserver();
   m_performance->updateLongTaskInstrumentation();
   EXPECT_TRUE(observingLongTasks());
 
   // Removing LongTask observer disables instrumentation.
   removeLongTaskObserver();
   m_performance->updateLongTaskInstrumentation();
   EXPECT_FALSE(observingLongTasks());
 }
 
 TEST_F(PerformanceTest, SanitizedLongTaskName) {
-  HeapHashSet<Member<Frame>> frameContexts;
   // Unable to attribute, when no execution contents are available.
-  EXPECT_EQ("unknown", sanitizedAttribution(frameContexts, frame()));
+  EXPECT_EQ("unknown", sanitizedAttribution(nullptr, false, frame()));
 
   // Attribute for same context (and same origin).
-  frameContexts.add(frame());
-  EXPECT_EQ("same-origin", sanitizedAttribution(frameContexts, frame()));
+  EXPECT_EQ("same-origin", sanitizedAttribution(document(), false, frame()));
 
   // Unable to attribute, when multiple script execution contents are involved.
-  frameContexts.add(anotherFrame());
-  EXPECT_EQ("multiple-contexts", sanitizedAttribution(frameContexts, frame()));
+  EXPECT_EQ("multiple-contexts",
+            sanitizedAttribution(document(), true, frame()));
 }
 
 TEST_F(PerformanceTest, SanitizedLongTaskName_CrossOrigin) {
-  HeapHashSet<Member<Frame>> frameContexts;
   // Unable to attribute, when no execution contents are available.
-  EXPECT_EQ("unknown", sanitizedAttribution(frameContexts, frame()));
+  EXPECT_EQ("unknown", sanitizedAttribution(nullptr, false, frame()));
 
   // Attribute for same context (and same origin).
-  frameContexts.add(anotherFrame());
   EXPECT_EQ("cross-origin-unreachable",
-            sanitizedAttribution(frameContexts, frame()));
+            sanitizedAttribution(anotherDocument(), false, frame()));
 }
 }