Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 2539293002: Fix learn more button positioning (Closed)

Created:
4 years ago by catmullings
Modified:
4 years ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, mac-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix learn more button positioning Fix regression in which the Learn more button is right aligned on the x-position, when instead it should be left aligned. BUG=668374 Committed: https://crrev.com/aebc5dfefce04c8a258d43cf6061b94b6fbe241d Cr-Commit-Position: refs/heads/master@{#435755}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac.mm View 1 chunk +13 lines, -13 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
catmullings
4 years ago (2016-11-30 23:00:09 UTC) #2
Devlin
lgtm, but we need a cocoa reviewer. Also, can you attach a screenshot either here ...
4 years ago (2016-11-30 23:46:05 UTC) #3
catmullings
On 2016/11/30 23:46:05, Devlin wrote: > lgtm, but we need a cocoa reviewer. > > ...
4 years ago (2016-12-01 02:07:54 UTC) #4
catmullings
4 years ago (2016-12-01 02:08:11 UTC) #6
catmullings
Here is a screenshot of the fix: https://bugs.chromium.org/p/chromium/issues/detail?id=668374#c4
4 years ago (2016-12-01 02:08:48 UTC) #8
Avi (use Gerrit)
lgtm
4 years ago (2016-12-01 15:56:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2539293002/1
4 years ago (2016-12-01 23:00:26 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-01 23:27:03 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-01 23:30:16 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aebc5dfefce04c8a258d43cf6061b94b6fbe241d
Cr-Commit-Position: refs/heads/master@{#435755}

Powered by Google App Engine
This is Rietveld 408576698