Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: third_party/WebKit/Source/core/input/ScrollManager.h

Issue 2539283002: Remove PlatformGestureEvent in favour of using WebGestureEvent (Closed)
Patch Set: Rebase and fix comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/input/ScrollManager.h
diff --git a/third_party/WebKit/Source/core/input/ScrollManager.h b/third_party/WebKit/Source/core/input/ScrollManager.h
index b7c6182a783e877555928968994193ce1d2a7fec..1740cb485ff607ca5fec5255c77c7152234d6328 100644
--- a/third_party/WebKit/Source/core/input/ScrollManager.h
+++ b/third_party/WebKit/Source/core/input/ScrollManager.h
@@ -25,7 +25,6 @@ class LayoutObject;
class LocalFrame;
class PaintLayer;
class PaintLayerScrollableArea;
-class PlatformGestureEvent;
class Scrollbar;
class ScrollState;
@@ -75,9 +74,9 @@ class CORE_EXPORT ScrollManager
// Handle the provided scroll gesture event, propagating down to child frames
// as necessary.
- WebInputEventResult handleGestureScrollEvent(const PlatformGestureEvent&);
+ WebInputEventResult handleGestureScrollEvent(const WebGestureEvent&);
majidvp 2016/12/15 17:40:45 nit: I expected to see a forward decl or an #inclu
dtapuska 2016/12/15 21:29:38 Done.
- WebInputEventResult handleGestureScrollEnd(const PlatformGestureEvent&);
+ WebInputEventResult handleGestureScrollEnd(const WebGestureEvent&);
bool isScrollbarHandlingGestures() const;
@@ -86,19 +85,18 @@ class CORE_EXPORT ScrollManager
// These functions are related to |m_resizeScrollableArea|.
bool inResizeMode() const;
- void resize(const PlatformEvent&);
+ void resize(const PlatformMouseEvent&);
// Clears |m_resizeScrollableArea|. if |shouldNotBeNull| is true this
// function DCHECKs to make sure that variable is indeed not null.
void clearResizeScrollableArea(bool shouldNotBeNull);
void setResizeScrollableArea(PaintLayer*, IntPoint);
private:
- WebInputEventResult handleGestureScrollUpdate(const PlatformGestureEvent&);
- WebInputEventResult handleGestureScrollBegin(const PlatformGestureEvent&);
+ WebInputEventResult handleGestureScrollUpdate(const WebGestureEvent&);
+ WebInputEventResult handleGestureScrollBegin(const WebGestureEvent&);
- WebInputEventResult passScrollGestureEventToWidget(
- const PlatformGestureEvent&,
- LayoutObject*);
+ WebInputEventResult passScrollGestureEventToWidget(const WebGestureEvent&,
+ LayoutObject*);
void clearGestureScrollState();
@@ -108,7 +106,7 @@ class CORE_EXPORT ScrollManager
bool isViewportScrollingElement(const Element&) const;
- bool handleScrollGestureOnResizer(Node*, const PlatformGestureEvent&);
+ bool handleScrollGestureOnResizer(Node*, const WebGestureEvent&);
void recomputeScrollChain(const Node& startNode,
std::deque<int>& scrollChain);

Powered by Google App Engine
This is Rietveld 408576698