Remove PlatformGestureEvent in favour of using WebGestureEvent

third_party/WebKit/Source/web/WebInputEventConversion.h

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 13 matching lines @@
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef WebInputEventConversion_h
 #define WebInputEventConversion_h
 
-#include "platform/PlatformGestureEvent.h"
 #include "platform/PlatformMouseEvent.h"
 #include "platform/PlatformTouchEvent.h"
 #include "platform/PlatformWheelEvent.h"
-#include "public/platform/WebGestureEvent.h"
+#include "platform/scroll/ScrollTypes.h"
 #include "public/platform/WebInputEvent.h"
 #include "web/WebExport.h"
 #include "wtf/Compiler.h"
 #include <vector>
 
 namespace blink {
 
-class GestureEvent;
 class KeyboardEvent;
 class MouseEvent;
 class LayoutItem;
 class TouchEvent;
 class WebMouseEvent;
 class WebMouseWheelEvent;
 class WebKeyboardEvent;
 class WebTouchEvent;
-class WebGestureEvent;
 class WheelEvent;

[majidvp, 2016/12/15 17:40:46]

nit: please either #include WebGestureEvent or forward decl it.

[dtapuska, 2016/12/15 21:29:39]

Done.

 class Widget;
 
 // These classes are used to convert from WebInputEvent subclasses to
 // corresponding WebCore events.
 
 class WEB_EXPORT PlatformMouseEventBuilder
     : NON_EXPORTED_BASE(public PlatformMouseEvent) {
  public:
   PlatformMouseEventBuilder(Widget*, const WebMouseEvent&);
 };
 
 class WEB_EXPORT PlatformWheelEventBuilder
     : NON_EXPORTED_BASE(public PlatformWheelEvent) {
  public:
   PlatformWheelEventBuilder(Widget*, const WebMouseWheelEvent&);
 };
 
-class WEB_EXPORT PlatformGestureEventBuilder
-    : NON_EXPORTED_BASE(public PlatformGestureEvent) {
- public:
-  PlatformGestureEventBuilder(Widget*, const WebGestureEvent&);
-};
-
 // Converts a WebTouchPoint to a PlatformTouchPoint.
 class WEB_EXPORT PlatformTouchPointBuilder
     : NON_EXPORTED_BASE(public PlatformTouchPoint) {
  public:
   PlatformTouchPointBuilder(Widget*, const WebTouchPoint&);
 };
 
 // Converts a WebTouchEvent to a PlatformTouchEvent.
 class WEB_EXPORT PlatformTouchEventBuilder
     : NON_EXPORTED_BASE(public PlatformTouchEvent) {
@@ skipping 32 matching lines @@
 
 // Converts a TouchEvent to a corresponding WebTouchEvent.
 // NOTE: WebTouchEvents have a cap on the number of WebTouchPoints. Any points
 // exceeding that cap will be dropped.
 class WEB_EXPORT WebTouchEventBuilder
     : NON_EXPORTED_BASE(public WebTouchEvent) {
  public:
   WebTouchEventBuilder(const LayoutItem, const TouchEvent&);
 };
 
-// Converts GestureEvent to a corresponding WebGestureEvent.
-// NOTE: If event mapping fails, the type will be set to Undefined.
-class WEB_EXPORT WebGestureEventBuilder
-    : NON_EXPORTED_BASE(public WebGestureEvent) {
- public:
-  WebGestureEventBuilder(const LayoutItem, const GestureEvent&);
-};
+WEB_EXPORT WebGestureEvent ScaleWebGestureEvent(Widget*,

[majidvp, 2016/12/15 17:40:46]

This is a scale & translate. I think a better name may be
TransformWebGestureEvent which is consistent with flattenTransform.

Also a comment to explain what is being transformed in relation to the widget is
useful.

[dtapuska, 2016/12/15 21:29:39]

Done.

+                                                const WebGestureEvent&);
 
 Vector<PlatformMouseEvent> WEB_EXPORT
 createPlatformMouseEventVector(Widget*,
                                const std::vector<const WebInputEvent*>&);
 Vector<PlatformTouchEvent> WEB_EXPORT
 createPlatformTouchEventVector(Widget*,
                                const std::vector<const WebInputEvent*>&);
 
 }  // namespace blink
 
 #endif