Remove PlatformGestureEvent in favour of using WebGestureEvent

third_party/WebKit/Source/core/input/EventHandlerTest.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/input/EventHandler.h"
 
 #include "core/dom/Document.h"
 #include "core/dom/Range.h"
 #include "core/editing/Editor.h"
 #include "core/editing/FrameSelection.h"
@@ skipping 15 matching lines @@
 
   Page& page() const { return m_dummyPageHolder->page(); }
   Document& document() const { return m_dummyPageHolder->document(); }
 
   void setHtmlInnerHTML(const char* htmlContent);
 
  private:
   std::unique_ptr<DummyPageHolder> m_dummyPageHolder;
 };
 
-class TapEventBuilder : public PlatformGestureEvent {
+class TapEventBuilder : public WebGestureEvent {
  public:
-  TapEventBuilder(IntPoint position, int tapCount)
-      : PlatformGestureEvent(PlatformEvent::GestureTap,
-                             position,
-                             position,
-                             IntSize(5, 5),
-                             WTF::monotonicallyIncreasingTime(),
-                             static_cast<PlatformEvent::Modifiers>(0),
-                             PlatformGestureSourceTouchscreen) {
-    m_data.m_tap.m_tapCount = tapCount;
+  TapEventBuilder(IntPoint position, int tapCount) : WebGestureEvent() {
+    type = WebInputEvent::GestureTap;
+    x = globalX = position.x();
+    y = globalY = position.y();
+    timeStampSeconds = WTF::monotonicallyIncreasingTime();
+    sourceDevice = WebGestureDeviceTouchscreen;
+    data.tap.tapCount = tapCount;
+    data.tap.width = 5;
+    data.tap.height = 5;

[majidvp, 2016/12/01 15:46:30]

One of the advantage of PlatformGestureEvent was that it had
constructors which helped ensure we initialize the data members
correctly. 

At the moment, tt is possible to construct WebGestureEvent 
incorrectly e.g., very easy to forget to initialize timeStampSeconds. Is there a
way to avoid this?

[dtapuska, 2016/12/01 16:26:43]

So my eventual goal is to have WebInputEvent be a full C++ class and then we can
have constructors. That can be done independently. I don't care for the wild
west struct.

   }
 };
 
 void EventHandlerTest::SetUp() {
   m_dummyPageHolder = DummyPageHolder::create(IntSize(300, 400));
 }
 
 void EventHandlerTest::setHtmlInnerHTML(const char* htmlContent) {
   document().documentElement()->setInnerHTML(String::fromUTF8(htmlContent));
   document().view()->updateAllLifecyclePhases();
@@ skipping 195 matching lines @@
   PlatformMouseEvent mouseDownEvent(
       IntPoint(0, 0), IntPoint(100, 200), WebPointerProperties::Button::Right,
       PlatformEvent::MousePressed, 1, PlatformEvent::Modifiers::RightButtonDown,
       WTF::monotonicallyIncreasingTime());
   EXPECT_EQ(
       WebInputEventResult::HandledApplication,
       document().frame()->eventHandler().sendContextMenuEvent(mouseDownEvent));
 }
 
 }  // namespace blink