Makes WindowTreeHostMus supply properties directly to window creation

ui/aura/mus/window_tree_host_mus.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/aura/mus/window_tree_host_mus.h"
 
 #include "base/memory/ptr_util.h"
 #include "ui/aura/env.h"
 #include "ui/aura/mus/input_method_mus.h"
 #include "ui/aura/mus/window_port_mus.h"
@@ skipping 71 matching lines @@
 
   // Mus windows are assumed hidden.
   compositor()->SetVisible(false);
 }
 
 WindowTreeHostMus::WindowTreeHostMus(
     WindowTreeClient* window_tree_client,
     const std::map<std::string, std::vector<uint8_t>>* properties)
     : WindowTreeHostMus(
           static_cast<WindowTreeHostMusDelegate*>(window_tree_client)
-              ->CreateWindowPortForTopLevel(),
+              ->CreateWindowPortForTopLevel(properties),
           window_tree_client,
           display::Screen::GetScreen()->GetPrimaryDisplay().id(),
           properties) {}

[msw, 2016/12/02 00:31:08]

The other constructor re-applies these properties; is that right?
Sorry, I'm a bit confused... not sure if this makes sense.

[sky, 2016/12/02 01:08:43]

Ya, sorry, I agree this is weird. WindowPort is the porting layer introduced for
mus. Each Window has an associated WindowPort. CreateWindowPortForTopLevel()
creates the WindowPort (not the Window) and asks the server to create the
representation of the window on its side. |properties| is supplied to
CreateWindowPortForTopLevel so properties can be passed to the server. The other
WindowTreeHostMus constructor (actually, the superclass) creates the Window with
the WindowPort created from WindowTreeClient. Then the properties are passed
through PropertyConverter and applied to the window.

The old code created the Window first, applied the properties to it, then when
the call to create the window on the server side was called the properties were
extracted from the Window and passed to the server. This meant any properties
not known to PropertyConverter were dropped on the floor. This is bad as some
properties are only useful during initial construction.

[msw, 2016/12/02 01:21:40]

Okay, thanks for the explanation, would a comment here be worthwhile?
(or is there somewhere else that documents this pattern?)

 
 WindowTreeHostMus::~WindowTreeHostMus() {
   DestroyCompositor();
   DestroyDispatcher();
 }
 
 void WindowTreeHostMus::SetBoundsFromServer(const gfx::Rect& bounds) {
   base::AutoReset<bool> resetter(&in_set_bounds_from_server_, true);
   SetBoundsInPixels(bounds);
 }
@@ skipping 51 matching lines @@
 void WindowTreeHostMus::OnCloseRequest() {
   OnHostCloseRequested();
 }
 
 gfx::ICCProfile WindowTreeHostMus::GetICCProfileForCurrentDisplay() {
   // TODO: This should read the profile from mus. crbug.com/647510
   return gfx::ICCProfile();
 }
 
 }  // namespace aura