predictors: Take RESOURCE_TYPE_XHR into account.

predictors: Take RESOURCE_TYPE_XHR into account.

Some useful subresources could be fetched by webpages via XMLHttpRequest. This
CL adds support of this type of requests to ResourcePrefetchPredictor.

BUG=631966
Committed: https://crrev.com/68b12e34f76bcd64a4764aeada8b962120b4b470
Cr-Commit-Position: refs/heads/master@{#435653}

[alexilin, 2016-12-01 15:41:15]

alexilin@chromium.org changed reviewers:
+ lizeb@chromium.org, pasko@chromium.org

[Benoit L, 2016-12-01 16:15:21]

https://codereview.chromium.org/2539263004/diff/1/chrome/browser/predictors/r...
File chrome/browser/predictors/resource_prefetch_predictor.cc (right):

https://codereview.chromium.org/2539263004/diff/1/chrome/browser/predictors/r...
chrome/browser/predictors/resource_prefetch_predictor.cc:225: resource_type ==
content::RESOURCE_TYPE_XHR) {
Can you add an assertion (or a few) in
ResourcePrefetchPredictorTest::HandledResourceTypes?

[pasko, 2016-12-01 16:18:36]

looks good, can you please add coverage in
resource_prefetch_predictor_unittest.cc?

[alexilin, 2016-12-01 16:40:13]

Sorry I didn't add tests at once.

[Benoit L, 2016-12-01 16:44:41]

On 2016/12/01 16:40:13, alexilin wrote:
> Sorry I didn't add tests at once.

lgtm, thanks.

[Benoit L, 2016-12-01 16:44:42]

On 2016/12/01 16:40:13, alexilin wrote:
> Sorry I didn't add tests at once.

lgtm, thanks.

[pasko, 2016-12-01 16:49:14]

lgtm, thank you

[alexilin, 2016-12-01 16:58:19]

The CQ bit was checked by alexilin@chromium.org

[commit-bot: I haz the power, 2016-12-01 16:58:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 18:23:37]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480611499457730,
"parent_rev": "ab2c2b5e9dd7d44d5de38d4f5f95309b52eecb1a", "commit_rev":
"2e31da41e3ea7e91579f83255150f7a00f151b0b"}

[commit-bot: I haz the power, 2016-12-01 18:24:05]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-01 18:26:59]

Description was changed from

==========
predictors: Take RESOURCE_TYPE_XHR into account.

Some useful subresources could be fetched by webpages via XMLHttpRequest. This
CL adds support of this type of requests to ResourcePrefetchPredictor.

BUG=631966
==========

to

==========
predictors: Take RESOURCE_TYPE_XHR into account.

Some useful subresources could be fetched by webpages via XMLHttpRequest. This
CL adds support of this type of requests to ResourcePrefetchPredictor.

BUG=631966

Committed: https://crrev.com/68b12e34f76bcd64a4764aeada8b962120b4b470
Cr-Commit-Position: refs/heads/master@{#435653}
==========

[commit-bot: I haz the power, 2016-12-01 18:27:00]

Patchset 2 (id:??) landed as
https://crrev.com/68b12e34f76bcd64a4764aeada8b962120b4b470
Cr-Commit-Position: refs/heads/master@{#435653}