Move Task Scheduler Initialization From chrome/browser to Content

components/task_scheduler_util/initialization/browser_util.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/task_scheduler_util/initialization/browser_util.h"
 
 #include <map>
 #include <string>
 
 #include "base/task_scheduler/initialization_util.h"
@@ skipping 66 matching lines @@
 // Returns the worker pool index for |traits| defaulting to FOREGROUND or
 // FOREGROUND_FILE_IO on any other priorities.
 size_t BrowserWorkerPoolIndexForTraits(const base::TaskTraits& traits) {
   const bool is_background =
       traits.priority() == base::TaskPriority::BACKGROUND;
   if (traits.with_file_io())
     return is_background ? BACKGROUND_FILE_IO : FOREGROUND_FILE_IO;
 
   return is_background ? BACKGROUND : FOREGROUND;
 }
 

[fdoray, 2016/12/07 13:46:12]

#if defined(OS_IOS) the whole function, to get a build error it it's called on
another platform than iOS

[robliao, 2016/12/08 01:04:22]

Done. For correctness, this is also propagated to initialization_util.

 std::vector<base::SchedulerWorkerPoolParams>
 GetDefaultBrowserSchedulerWorkerPoolParams() {
   constexpr size_t kNumWorkerPoolsDefined =
       sizeof(BrowserWorkerPoolsConfiguration) /
       sizeof(SingleWorkerPoolConfiguration);
   static_assert(kNumWorkerPoolsDefined == 4,
                 "Expected 4 worker pools in BrowserWorkerPoolsConfiguration");
   BrowserWorkerPoolsConfiguration config;
   constexpr size_t kSizeAssignedFields =
       sizeof(config.background.threads) +
       sizeof(config.background.detach_period) +
       sizeof(config.background.standby_thread_policy);
   static_assert(kSizeAssignedFields == sizeof(config.background),
                 "Not all fields were assigned");
-#if defined(OS_ANDROID) || defined(OS_IOS)
+#if defined(OS_IOS)
   config.background.standby_thread_policy = StandbyThreadPolicy::ONE;
   config.background.threads =
       base::RecommendedMaxNumberOfThreadsInPool(2, 8, 0.1, 0);
   config.background.detach_period = base::TimeDelta::FromSeconds(30);
 
   config.background_file_io.standby_thread_policy = StandbyThreadPolicy::ONE;
   config.background_file_io.threads =
       base::RecommendedMaxNumberOfThreadsInPool(2, 8, 0.1, 0);
   config.background_file_io.detach_period = base::TimeDelta::FromSeconds(30);
 
   config.foreground.standby_thread_policy = StandbyThreadPolicy::ONE;
   config.foreground.threads =
       base::RecommendedMaxNumberOfThreadsInPool(3, 8, 0.3, 0);
   config.foreground.detach_period = base::TimeDelta::FromSeconds(30);
 
   config.foreground_file_io.standby_thread_policy = StandbyThreadPolicy::ONE;
   config.foreground_file_io.threads =
       base::RecommendedMaxNumberOfThreadsInPool(3, 8, 0.3, 0);
   config.foreground_file_io.detach_period = base::TimeDelta::FromSeconds(30);
 #else
-  config.background.standby_thread_policy = StandbyThreadPolicy::ONE;
-  config.background.threads =
-      base::RecommendedMaxNumberOfThreadsInPool(3, 8, 0.1, 0);
-  config.background.detach_period = base::TimeDelta::FromSeconds(30);
-
-  config.background_file_io.standby_thread_policy = StandbyThreadPolicy::ONE;
-  config.background_file_io.threads =
-      base::RecommendedMaxNumberOfThreadsInPool(3, 8, 0.1, 0);
-  config.background_file_io.detach_period = base::TimeDelta::FromSeconds(30);
-
-  config.foreground.standby_thread_policy = StandbyThreadPolicy::ONE;
-  config.foreground.threads =
-      base::RecommendedMaxNumberOfThreadsInPool(8, 32, 0.3, 0);
-  config.foreground.detach_period = base::TimeDelta::FromSeconds(30);
-
-  config.foreground_file_io.standby_thread_policy = StandbyThreadPolicy::ONE;
-  config.foreground_file_io.threads =
-      base::RecommendedMaxNumberOfThreadsInPool(8, 32, 0.3, 0);
-  config.foreground_file_io.detach_period = base::TimeDelta::FromSeconds(30);
+  NOTREACHED() << "No default configuration available for this platform.";
 #endif
   return BrowserWorkerPoolConfigurationToSchedulerWorkerPoolParams(config);
 }
 
 }  // namespace initialization
 }  // namespace task_scheduler_util