Issue 253923005: Fix android_arm.debug after r20051

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 253923005: Fix android_arm.debug after r20051 (Closed)

Created:
6 years, 7 months ago by rmcilroy

Modified:
6 years, 7 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix android_arm.debug after r20051 The ConstantPoolBuilder stores RelocInfo in an stl::vector, therefore RelocInfo cannot subclass BASE_EMBEDDED. R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21056

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix nit #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	src/arm/assembler-arm.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
	M	src/assembler.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

lgtm https://codereview.chromium.org/253923005/diff/1/src/arm/assembler-arm.h File src/arm/assembler-arm.h (right): https://codereview.chromium.org/253923005/diff/1/src/arm/assembler-arm.h#newcode732 src/arm/assembler-arm.h:732: // RelocInfo would need to subclass Zone which ...

6 years, 7 months ago (2014-04-29 14:01:06 UTC) #2

rmcilroy

https://codereview.chromium.org/253923005/diff/1/src/arm/assembler-arm.h File src/arm/assembler-arm.h (right): https://codereview.chromium.org/253923005/diff/1/src/arm/assembler-arm.h#newcode732 src/arm/assembler-arm.h:732: // RelocInfo would need to subclass Zone which it ...

6 years, 7 months ago (2014-04-29 14:11:51 UTC) #3

rmcilroy

6 years, 7 months ago (2014-04-29 14:14:13 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r21056 (presubmit successful).

Expand Messages | Collapse Messages