Fix InMemoryUrlProtocol available_bytes computation.

Fix InMemoryUrlProtocol available_bytes computation.

Fixed available_bytes computation to properly handle large buffers and
add defensive logic to Read() to protect against negative sizes.

BUG=364065
TESTS=InMemoryUrlProtocolTest.*

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267280

[scherkus (not reviewing), 2014-04-29 17:49:34]

lgtm w/ nits

https://codereview.chromium.org/253923002/diff/1/media/filters/in_memory_url_...
File media/filters/in_memory_url_protocol_unittest.cc (right):

https://codereview.chromium.org/253923002/diff/1/media/filters/in_memory_url_...
media/filters/in_memory_url_protocol_unittest.cc:13: class
InMemoryUrlProtocolTest : public testing::Test {
if you don't need the fixture, you can drop this and s/TEST_F/TEST/g

https://codereview.chromium.org/253923002/diff/1/media/filters/in_memory_url_...
media/filters/in_memory_url_protocol_unittest.cc:17: InMemoryUrlProtocol
protocol(kData, 2147483649, false);
seasoned vets will recognize this as 2^31 + 1

... but why don't we make it a bit more obvious with something like:

int64 size = std::numeric_limits<int32>::max();
size += 1;

or, heck std::numeric_limits<int64>::max() ?!

https://codereview.chromium.org/253923002/diff/1/media/filters/in_memory_url_...
media/filters/in_memory_url_protocol_unittest.cc:54: 
remove extra line

[acolwell GONE FROM CHROMIUM, 2014-04-29 22:46:04]

https://codereview.chromium.org/253923002/diff/1/media/filters/in_memory_url_...
File media/filters/in_memory_url_protocol_unittest.cc (right):

https://codereview.chromium.org/253923002/diff/1/media/filters/in_memory_url_...
media/filters/in_memory_url_protocol_unittest.cc:13: class
InMemoryUrlProtocolTest : public testing::Test {
On 2014/04/29 17:49:34, scherkus wrote:
> if you don't need the fixture, you can drop this and s/TEST_F/TEST/g

Done.

https://codereview.chromium.org/253923002/diff/1/media/filters/in_memory_url_...
media/filters/in_memory_url_protocol_unittest.cc:17: InMemoryUrlProtocol
protocol(kData, 2147483649, false);
On 2014/04/29 17:49:34, scherkus wrote:
> seasoned vets will recognize this as 2^31 + 1
> 
> ... but why don't we make it a bit more obvious with something like:
> 
> int64 size = std::numeric_limits<int32>::max();
> size += 1;
> 
> or, heck std::numeric_limits<int64>::max() ?! 

Done.

[acolwell GONE FROM CHROMIUM, 2014-04-29 22:46:08]

The CQ bit was checked by acolwell@chromium.org

[commit-bot: I haz the power, 2014-04-29 22:49:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/acolwell@chromium.org/253923002/20001

[commit-bot: I haz the power, 2014-04-29 22:57:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-29 22:57:57]

Try jobs failed on following builders:
  android_clang_dbg on tryserver.chromium

[acolwell GONE FROM CHROMIUM, 2014-04-29 23:09:46]

The CQ bit was checked by acolwell@chromium.org

[commit-bot: I haz the power, 2014-04-29 23:14:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/acolwell@chromium.org/253923002/40001

[commit-bot: I haz the power, 2014-04-29 23:32:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-29 23:32:39]

Try jobs failed on following builders:
  android_clang_dbg on tryserver.chromium

[acolwell GONE FROM CHROMIUM, 2014-04-29 23:57:23]

The CQ bit was checked by acolwell@chromium.org

[commit-bot: I haz the power, 2014-04-29 23:58:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/acolwell@chromium.org/253923002/60001

[commit-bot: I haz the power, 2014-04-30 00:59:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-30 00:59:30]

Try jobs failed on following builders:
  win_chromium_rel on tryserver.chromium

[acolwell GONE FROM CHROMIUM, 2014-04-30 16:26:39]

The CQ bit was checked by acolwell@chromium.org

[commit-bot: I haz the power, 2014-04-30 16:27:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/acolwell@chromium.org/253923002/60001

[commit-bot: I haz the power, 2014-04-30 18:56:23]

Change committed as 267280