Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2539213002:
Add more extensions to the list. (Closed)
|
Created:
4 years ago by Denis Kuznetsov (DE-MUC) Modified:
4 years ago CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd more extensions to the list of extensions enabled on login screen.
BUG=626342
Committed: https://crrev.com/87e0ccf1fe6b6b3b31842e621bb09f19c768f36d
Cr-Commit-Position: refs/heads/master@{#435625}
Patch Set 1 #
Total comments: 3
Patch Set 2 : +Chrome OS XKB #Messages
Total messages: 17 (10 generated)
Description was changed from ========== Add more extensions to the list. BUG=626342 ========== to ========== Add more extensions to the list of extensions enabled on login screen. BUG=626342 ==========
antrim@chromium.org changed reviewers: + asargent@chromium.org, emaxx@chromium.org
It seems that initial extension list not complete, this CL adds few more exceptions that might appear on the login screen.
lgtm
https://codereview.chromium.org/2539213002/diff/1/extensions/common/api/_beha... File extensions/common/api/_behavior_features.json (left): https://codereview.chromium.org/2539213002/diff/1/extensions/common/api/_beha... extensions/common/api/_behavior_features.json:78: "location": "external_component", This restriction seems too strict: Virtaul Keyboard is loaded as extension, not a component app. Is there any chance for a side-loaded extension to have the same ID as for a component extension? https://codereview.chromium.org/2539213002/diff/1/extensions/common/api/_beha... File extensions/common/api/_behavior_features.json (right): https://codereview.chromium.org/2539213002/diff/1/extensions/common/api/_beha... extensions/common/api/_behavior_features.json:89: "2FCBCE08B34CCA1728A85F1EFBD9A34DD2558B2E" // ChromeVox We can also include Chrome PDF Viewer to this list, it now attempts to load on login screen, but I wonder if it is really needed there.
https://codereview.chromium.org/2539213002/diff/1/extensions/common/api/_beha... File extensions/common/api/_behavior_features.json (left): https://codereview.chromium.org/2539213002/diff/1/extensions/common/api/_beha... extensions/common/api/_behavior_features.json:78: "location": "external_component", On 2016/11/30 23:22:33, Denis Kuznetsov (DE-MUC) wrote: > This restriction seems too strict: Virtaul Keyboard is loaded as extension, not > a component app. > Is there any chance for a side-loaded extension to have the same ID as for a > component extension? If by "side loaded" you mean loaded in development mode from chrome://extensions, then yes, any extension id can be spoofed if you have the corresponding public key (taken from the "key" field of the manifest"). If by "side loaded" you mean an extension installed via a mechanism like drag/drop of a .crx file onto the chrome://extensions page, or via policy or external extensions (https://developer.chrome.com/extensions/external_extensions but probably not relevant to ChromeOS), then no, it is not possible to spoof an id unless you have the private key to sign the .crx file with.
The CQ bit was checked by antrim@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by antrim@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480609809273440,
"parent_rev": "97eb5ff174fd91d4f01b782f81ed7338e3775edb", "commit_rev":
"5eebfe13be9bb5aab0c2e7ce76818006670ad834"}
Message was sent while issue was closed.
Description was changed from ========== Add more extensions to the list of extensions enabled on login screen. BUG=626342 ========== to ========== Add more extensions to the list of extensions enabled on login screen. BUG=626342 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Add more extensions to the list of extensions enabled on login screen. BUG=626342 ========== to ========== Add more extensions to the list of extensions enabled on login screen. BUG=626342 Committed: https://crrev.com/87e0ccf1fe6b6b3b31842e621bb09f19c768f36d Cr-Commit-Position: refs/heads/master@{#435625} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/87e0ccf1fe6b6b3b31842e621bb09f19c768f36d Cr-Commit-Position: refs/heads/master@{#435625} |
