xfa/fxfa/parser/cxfa_node.cpp - Issue 2539203002: Convert loose FX_Create* functions into static methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fxfa/parser/cxfa_node.cpp

Issue 2539203002: Convert loose FX_Create* functions into static methods (Closed)

Patch Set: last batch Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fxfa/parser/cxfa_node.cpp

diff --git a/xfa/fxfa/parser/cxfa_node.cpp b/xfa/fxfa/parser/cxfa_node.cpp

index 18ea41419a1d2fc2a24fc3bc518bc6ce5677a20c..05ddcfc71b9ef95c1636c05a105ddd63f0ec74e7 100644

--- a/xfa/fxfa/parser/cxfa_node.cpp

+++ b/xfa/fxfa/parser/cxfa_node.cpp

@@ -1442,7 +1442,7 @@ void CXFA_Node::Script_NodeClass_SaveXML(CFXJSE_Arguments* pArguments) {

XFA_DataExporter_DealWithDataGroupNode(this);

}

std::unique_ptr<IFX_MemoryStream, ReleaseDeleter<IFX_MemoryStream>>

- pMemoryStream(FX_CreateMemoryStream(true));

+ pMemoryStream(IFX_MemoryStream::Create(true));

std::unique_ptr<IFX_Stream, ReleaseDeleter<IFX_Stream>> pStream(

IFX_Stream::CreateStream(

static_cast<IFX_SeekableWriteStream*>(pMemoryStream.get()),