Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 2539183004: Introduce constants for histogram names in tests. (Closed)

Created:
4 years ago by pkalinnikov
Modified:
4 years ago
Reviewers:
engedy
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce constants for histogram names in tests. BUG=609747 Committed: https://crrev.com/6292cb3b2068b52108e54fcb70c23f1414ca5753 Cr-Commit-Position: refs/heads/master@{#435608}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -58 lines) Patch
M components/subresource_filter/content/renderer/subresource_filter_agent.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/subresource_filter/content/renderer/subresource_filter_agent_unittest.cc View 5 chunks +55 lines, -58 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
pkalinnikov
Balazs, PTAL.
4 years ago (2016-12-01 14:10:06 UTC) #4
engedy
LGTM. This makes the tests much easier to read. I would leave the inline literals ...
4 years ago (2016-12-01 14:11:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2539183004/1
4 years ago (2016-12-01 15:00:47 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-01 15:05:30 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-01 15:08:52 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6292cb3b2068b52108e54fcb70c23f1414ca5753
Cr-Commit-Position: refs/heads/master@{#435608}

Powered by Google App Engine
This is Rietveld 408576698