Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(640)

Issue 2539183003: Don't log a console warning when touch-action is used. (Closed)

Created:
4 years ago by dtapuska
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Don't log a console warning when touch-action is used. To avoid log fatigue for the developer only log the "you are prevent defaulting a passive event listener" if no touch-action is used. If touch-action is being used then it is clear that the developer is doing this to interop with other browsers that don't support touch-action. BUG=667799 Review-Url: https://codereview.chromium.org/2520423004 Cr-Commit-Position: refs/heads/master@{#434536} (cherry picked from commit 6ea5974532e7cfea654c59181f1819e6805bb368) Committed: https://chromium.googlesource.com/chromium/src/+/b7c3c8eb86af25ebba9d0254458a443a65a7c623

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -30 lines) Patch
A third_party/WebKit/LayoutTests/fast/events/touch/touch-action-preventDefault.html View 1 chunk +28 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/events/touch/touch-action-preventDefault-expected.txt View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/events/Event.cpp View 1 chunk +3 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/core/events/TouchEvent.cpp View 3 chunks +32 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
dtapuska
4 years ago (2016-11-30 22:13:31 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b7c3c8eb86af25ebba9d0254458a443a65a7c623.

Powered by Google App Engine
This is Rietveld 408576698