Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1548)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2539183002: blimp: Cleanup class/struct forward declarations (Closed)

Created:
4 years ago by jbriance
Modified:
4 years ago
Reviewers:
nyquist, Kevin M
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, nyquist+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, cbentzel+watch_chromium.org, maniscalco+watch-blimp_chromium.org, perumaal+watch-blimp_chromium.org, bgoldman+watch-blimp_chromium.org, gcasto+watch-blimp_chromium.org, abarth-chromium, marcinjb+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, scf+watch-blimp_chromium.org, khushalsagar+watch-blimp_chromium.org, anandc+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, steimel+watch-blimp_chromium.org, Aaron Boodman, darin (slow to review), dtrainor+watch-blimp_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

blimp: Cleanup class/struct forward declarations Remove useless class and struct forward declarations, and add missing ones in blimp header files. BUG=662195 Committed: https://crrev.com/ff6d7b1b3f9e951dcbc994e14419c6e919373ec4 Cr-Commit-Position: refs/heads/master@{#435468}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -93 lines) Patch
M blimp/client/app/android/blimp_client_session_android.h View 1 chunk +0 lines, -2 lines 0 comments Download
M blimp/client/app/session/blimp_client_session.h View 1 chunk +0 lines, -8 lines 0 comments Download
M blimp/client/core/compositor/blimp_compositor.h View 2 chunks +0 lines, -9 lines 0 comments Download
M blimp/client/core/contents/android/blimp_navigation_controller_impl_android.h View 1 chunk +0 lines, -2 lines 0 comments Download
M blimp/client/core/contents/blimp_contents_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M blimp/client/core/contents/blimp_navigation_controller_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M blimp/client/core/session/assignment_source.h View 1 chunk +0 lines, -1 line 0 comments Download
M blimp/client/core/settings/android/blimp_settings_android.h View 1 chunk +0 lines, -1 line 0 comments Download
M blimp/client/public/blimp_client_context.h View 1 chunk +0 lines, -4 lines 0 comments Download
M blimp/client/public/contents/blimp_contents.h View 1 chunk +0 lines, -4 lines 0 comments Download
M blimp/client/public/contents/blimp_navigation_controller.h View 1 chunk +0 lines, -2 lines 0 comments Download
M blimp/client/support/compositor/blimp_embedder_compositor.h View 1 chunk +0 lines, -1 line 0 comments Download
M blimp/client/support/compositor/blimp_layer_tree_settings.h View 1 chunk +0 lines, -8 lines 0 comments Download
M blimp/client/support/compositor/compositor_dependencies_impl.h View 1 chunk +0 lines, -4 lines 0 comments Download
M blimp/client/test/compositor/test_blimp_embedder_compositor.h View 1 chunk +0 lines, -6 lines 0 comments Download
M blimp/common/create_blimp_message.h View 1 chunk +0 lines, -1 line 0 comments Download
M blimp/engine/app/blimp_content_browser_client.h View 1 chunk +0 lines, -4 lines 0 comments Download
M blimp/engine/app/blimp_system_url_request_context_getter.h View 1 chunk +0 lines, -1 line 0 comments Download
M blimp/engine/app/blimp_url_request_context_getter.h View 1 chunk +0 lines, -3 lines 0 comments Download
M blimp/engine/browser_tests/blimp_browser_test.h View 1 chunk +0 lines, -8 lines 0 comments Download
M blimp/engine/mojo/font_fetcher_mojo_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M blimp/engine/renderer/engine_image_serialization_processor.h View 1 chunk +0 lines, -4 lines 0 comments Download
M blimp/engine/session/blimp_engine_session.h View 2 chunks +0 lines, -4 lines 0 comments Download
M blimp/net/blimp_message_multiplexer.h View 1 chunk +0 lines, -1 line 0 comments Download
M blimp/net/blimp_message_output_buffer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M blimp/net/blimp_message_thread_pipe.h View 1 chunk +0 lines, -1 line 0 comments Download
M blimp/net/engine_authentication_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M blimp/net/engine_connection_manager.h View 1 chunk +0 lines, -2 lines 0 comments Download
M blimp/net/input_message_generator.h View 1 chunk +0 lines, -1 line 0 comments Download
M blimp/net/ssl_client_transport.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
jbriance
4 years ago (2016-11-30 16:47:01 UTC) #2
nyquist
lgtm
4 years ago (2016-11-30 22:27:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2539183002/1
4 years ago (2016-11-30 22:47:26 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-30 23:21:12 UTC) #7
commit-bot: I haz the power
4 years ago (2016-11-30 23:22:48 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/ff6d7b1b3f9e951dcbc994e14419c6e919373ec4
Cr-Commit-Position: refs/heads/master@{#435468}

Powered by Google App Engine
This is Rietveld 408576698