Issue 2539173002: VM: [Kernel] Allocate objects in KernelReader/kernel::FlowGraphBuilder in Heap::kOld if appropriate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2539173002: VM: [Kernel] Allocate objects in KernelReader/kernel::FlowGraphBuilder in Heap::kOld if appropriate (Closed)

Created:
4 years ago by kustermann

Modified:
4 years ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

VM: [Kernel] Allocate objects in KernelReader/kernel::FlowGraphBuilder in Heap::kOld if appropriate If we generate too much surviving objects in Heap::kNew during program reading time or flow graph construction time we trigger (very aggressive) growth of new space. R=vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/ff8951a515e5b8399a6e7af1028d976a7ad3cf51

Created: 4 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -8 lines)			Patch
M	runtime/vm/kernel_reader.cc	View		3 chunks	+5 lines, -5 lines	0 comments	Download
M	runtime/vm/kernel_to_il.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/co19/co19-kernel.status	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 5 (2 generated)

kustermann

4 years ago (2016-12-01 12:51:37 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
ff8951a515e5b8399a6e7af1028d976a7ad3cf51 (presubmit successful).