Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 2539163003: Add command buffer support for GL_EXT_texture_sRGB_decode (Closed)

Created:
4 years ago by ccameron
Modified:
4 years ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add command buffer support for GL_EXT_texture_sRGB_decode BUG=655247 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/e0e73c7fd74ed796a0b57748fcc7c740d0a51220 Cr-Commit-Position: refs/heads/master@{#435666}

Patch Set 1 #

Patch Set 2 : Remove unnecessary state tracking #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -0 lines) Patch
M gpu/command_buffer/build_gles2_cmd_buffer.py View 1 chunk +8 lines, -0 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils_autogen.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h View 1 chunk +9 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/feature_info.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_validation_autogen.h View 1 chunk +6 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_validation_implementation_autogen.h View 1 chunk +10 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/texture_manager.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 22 (16 generated)
ccameron
ptal -- this one is fairly trivial
4 years ago (2016-12-01 01:27:28 UTC) #3
Zhenyao Mo
On 2016/12/01 01:27:28, ccameron wrote: > ptal -- this one is fairly trivial lgtm
4 years ago (2016-12-01 01:40:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2539163003/60001
4 years ago (2016-12-01 18:58:12 UTC) #17
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years ago (2016-12-01 19:04:05 UTC) #19
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/e0e73c7fd74ed796a0b57748fcc7c740d0a51220 Cr-Commit-Position: refs/heads/master@{#435666}
4 years ago (2016-12-01 19:06:12 UTC) #21
enne (OOO)
4 years ago (2016-12-01 23:44:41 UTC) #22
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2544903003/ by enne@chromium.org.

The reason for reverting is: Patch that this depends on breaks gl_tests

BUG=670487.

Powered by Google App Engine
This is Rietveld 408576698