Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issue 2539153003: Ensure that new toolbar actions added to incognito toolbars become visible (Closed)

Created:
4 years ago by takumif
Modified:
4 years ago
Reviewers:
Devlin
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ensure that new toolbar actions added to incognito toolbars become visible When a new action is added to the incognito toolbar (which can happen with the Media Router component action), it should become visible regardless of the state of the non-incognito toolbar. This change ensures that and adds a unit test. BUG=668039 Committed: https://crrev.com/3a17a81205b7482b758b8fdad29aa7d759742f50 Cr-Commit-Position: refs/heads/master@{#435675}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -1 line) Patch
M chrome/browser/ui/toolbar/toolbar_actions_model.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/toolbar/toolbar_actions_model_unittest.cc View 1 chunk +44 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
takumif
Please take a look, thank you!
4 years ago (2016-11-30 22:10:19 UTC) #4
Devlin
lgtm
4 years ago (2016-12-01 16:06:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2539153003/1
4 years ago (2016-12-01 19:22:13 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-01 19:26:45 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-01 19:29:59 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3a17a81205b7482b758b8fdad29aa7d759742f50
Cr-Commit-Position: refs/heads/master@{#435675}

Powered by Google App Engine
This is Rietveld 408576698