Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2539133002: Fix MIPS maddf and msubf instructions in simulator and tests. (Closed)

Created:
4 years ago by predrag.rudic
Modified:
4 years ago
Reviewers:
ivica.bogosavljevic, miran.karic.imgtec, v8-mips-ports
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix MIPS maddf and msubf instructions in simulator and tests. Tests were falling in qemu because of inexact computation in tests. After correcting tests, simulator also had to be fixed. Committed: https://crrev.com/11f0a0e8196b71c6d6f6374f741111e7a8fde0a1 Cr-Commit-Position: refs/heads/master@{#41447}

Patch Set 1 #

Patch Set 2 : Fix error #

Patch Set 3 : Fix of errors. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -12 lines) Patch
M src/mips/simulator-mips.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/mips64/simulator-mips64.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/test-assembler-mips.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M test/cctest/test-assembler-mips64.cc View 1 2 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
predrag.rudic
PTAL
4 years ago (2016-12-01 09:12:41 UTC) #3
ivica.bogosavljevic
lgtm
4 years ago (2016-12-01 10:34:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2539133002/40001
4 years ago (2016-12-02 09:09:52 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-02 09:11:56 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-02 09:12:13 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/11f0a0e8196b71c6d6f6374f741111e7a8fde0a1
Cr-Commit-Position: refs/heads/master@{#41447}

Powered by Google App Engine
This is Rietveld 408576698