Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1156)

Unified Diff: content/browser/renderer_host/render_widget_host_impl.cc

Issue 253913003: Remove RenderWidgetHostView*::DidUpdateBackingStore. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_impl.cc
diff --git a/content/browser/renderer_host/render_widget_host_impl.cc b/content/browser/renderer_host/render_widget_host_impl.cc
index 2f6e180436ca3e56578ce52802e916d035139dc4..5c70df65e236ddd42d68eb2f9b6f05cae68b8868 100644
--- a/content/browser/renderer_host/render_widget_host_impl.cc
+++ b/content/browser/renderer_host/render_widget_host_impl.cc
@@ -1605,23 +1605,6 @@ void RenderWidgetHostImpl::DidUpdateBackingStore(
if (is_hidden_)
return;
- // Now paint the view. Watch out: it might be destroyed already.
- if (view_ && !is_accelerated_compositing_active_) {
-
- std::vector<ui::LatencyInfo> latency_info;
- for (size_t i = 0; i < params.latency_info.size(); i++) {
- ui::LatencyInfo info = params.latency_info[i];
- AddLatencyInfoComponentIds(&info);
- latency_info.push_back(info);
- }
-
- view_being_painted_ = true;
- view_->DidUpdateBackingStore(params.scroll_rect, params.scroll_delta,
- params.copy_rects, latency_info);
- view_->DidReceiveRendererFrame();
- view_being_painted_ = false;
- }
-
// If we got a resize ack, then perhaps we have another resize to send?
bool is_resize_ack =
ViewHostMsg_UpdateRect_Flags::is_resize_ack(params.flags);
@@ -1632,16 +1615,6 @@ void RenderWidgetHostImpl::DidUpdateBackingStore(
TimeTicks now = TimeTicks::Now();
TimeDelta delta = now - update_start;
UMA_HISTOGRAM_TIMES("MPArch.RWH_DidUpdateBackingStore", delta);
-
- // Measures the time from receiving the MsgUpdateRect IPC to completing the
- // DidUpdateBackingStore() method. On platforms which have asynchronous
- // painting, such as Linux, this is the sum of MPArch.RWH_OnMsgUpdateRect,
- // MPArch.RWH_DidUpdateBackingStore, and the time spent asynchronously
- // waiting for the paint to complete.
- //
- // On other platforms, this will be equivalent to MPArch.RWH_OnMsgUpdateRect.
- delta = now - paint_start;
- UMA_HISTOGRAM_TIMES("MPArch.RWH_TotalPaintTime", delta);
}
void RenderWidgetHostImpl::OnQueueSyntheticGesture(

Powered by Google App Engine
This is Rietveld 408576698