Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2539113002:
[wrapper-tracing] Fix WebGL extension and attachment handling (Closed)
|
Created:
4 years ago by Michael Lippautz Modified:
4 years ago CC:
Marcel Hlopko, blink-reviews, chromium-reviews, haraken, Ken Russell (switch to Gerrit) Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[wrapper-tracing] Fix WebGL extension and attachment handling
Fixes a wrapper tracing issue where ExtensionTracker and WebGLAttachment were
not handled properly. Has no affect on regular Oilpan garbage collection.
With wrapper tracing enabled this could've resulting in wrappers for typed
extensions and attachments being prematurely collected.
The issue was flushed out when we were able to generate compile-time errors
instead of having a catch-all dispatcher at runtime in
http://crrev.com/2533383003.
BUG=chromium:468240
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Committed: https://crrev.com/fb0beca59e6cc67a6f5b599476c8a3b27ce0418b
Committed: https://crrev.com/3b2400e88f4e7ef5cf0ff0e271a76da5c9d32a0f
Cr-Original-Commit-Position: refs/heads/master@{#435262}
Cr-Commit-Position: refs/heads/master@{#436263}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Fix wrapper tracing methods #
Total comments: 8
Patch Set 3 : Removed unused ctors #Patch Set 4 : Rebase #
Messages
Total messages: 39 (21 generated)
Description was changed from ========== [wrapper-tracing] Fix WebGL extension and attachment handling Fixes a wrapper tracing issue where ExtensionTracker and WebGLAttachment were not handled properly. Has no affect on regular Oilpan garbage collection. BUG=chromium:468240 ========== to ========== [wrapper-tracing] Fix WebGL extension and attachment handling Fixes a wrapper tracing issue where ExtensionTracker and WebGLAttachment were not handled properly. Has no affect on regular Oilpan garbage collection. BUG=chromium:468240 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Description was changed from ========== [wrapper-tracing] Fix WebGL extension and attachment handling Fixes a wrapper tracing issue where ExtensionTracker and WebGLAttachment were not handled properly. Has no affect on regular Oilpan garbage collection. BUG=chromium:468240 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== [wrapper-tracing] Fix WebGL extension and attachment handling Fixes a wrapper tracing issue where ExtensionTracker and WebGLAttachment were not handled properly. Has no affect on regular Oilpan garbage collection. The issue was flushed out when we were able to generate compile-time errors instead of having a catch-all dispatcher in crrev.com/2533383003. BUG=chromium:468240 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Description was changed from ========== [wrapper-tracing] Fix WebGL extension and attachment handling Fixes a wrapper tracing issue where ExtensionTracker and WebGLAttachment were not handled properly. Has no affect on regular Oilpan garbage collection. The issue was flushed out when we were able to generate compile-time errors instead of having a catch-all dispatcher in crrev.com/2533383003. BUG=chromium:468240 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== [wrapper-tracing] Fix WebGL extension and attachment handling Fixes a wrapper tracing issue where ExtensionTracker and WebGLAttachment were not handled properly. Has no affect on regular Oilpan garbage collection. The issue was flushed out when we were able to generate compile-time errors instead of having a catch-all dispatcher in http://crrev.com/2533383003. BUG=chromium:468240 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Description was changed from ========== [wrapper-tracing] Fix WebGL extension and attachment handling Fixes a wrapper tracing issue where ExtensionTracker and WebGLAttachment were not handled properly. Has no affect on regular Oilpan garbage collection. The issue was flushed out when we were able to generate compile-time errors instead of having a catch-all dispatcher in http://crrev.com/2533383003. BUG=chromium:468240 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== [wrapper-tracing] Fix WebGL extension and attachment handling Fixes a wrapper tracing issue where ExtensionTracker and WebGLAttachment were not handled properly. Has no affect on regular Oilpan garbage collection. With wrapper tracing enabled this could've resulting in wrappers for typed extensions and attachments being prematurely collected. The issue was flushed out when we were able to generate compile-time errors instead of having a catch-all dispatcher at runtime in http://crrev.com/2533383003. BUG=chromium:468240 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Description was changed from ========== [wrapper-tracing] Fix WebGL extension and attachment handling Fixes a wrapper tracing issue where ExtensionTracker and WebGLAttachment were not handled properly. Has no affect on regular Oilpan garbage collection. With wrapper tracing enabled this could've resulting in wrappers for typed extensions and attachments being prematurely collected. The issue was flushed out when we were able to generate compile-time errors instead of having a catch-all dispatcher at runtime in http://crrev.com/2533383003. BUG=chromium:468240 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== [wrapper-tracing] Fix WebGL extension and attachment handling Fixes a wrapper tracing issue where ExtensionTracker and WebGLAttachment were not handled properly. Has no affect on regular Oilpan garbage collection. With wrapper tracing enabled this could've resulting in wrappers for typed extensions and attachments being prematurely collected. The issue was flushed out when we were able to generate compile-time errors instead of having a catch-all dispatcher at runtime in http://crrev.com/2533383003. BUG=chromium:468240 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
mlippautz@chromium.org changed reviewers: + haraken@chromium.org
After wrapping my head around how to remove our catch-all handler and make tracing a non-traceable object a compile time failure in https://crrev.com/2533383003/ this issue got flushed out. kbr: fyi. Presumably this is unrelated to the issue you are hunting down since wrapper tracing has only been enabled for ~1 week.
hlopko@chromium.org changed reviewers: + hlopko@chromium.org
lgtm
The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM https://codereview.chromium.org/2539113002/diff/1/third_party/WebKit/Source/m... File third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp (right): https://codereview.chromium.org/2539113002/diff/1/third_party/WebKit/Source/m... third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp:62: TraceWrapperMember<WebGLRenderbuffer> m_renderbuffer; How did you notice that these things need to be TraceWrapperMember?
kbr: If something is unclear let's chat next week. I will be on vacation till then. https://codereview.chromium.org/2539113002/diff/1/third_party/WebKit/Source/m... File third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp (right): https://codereview.chromium.org/2539113002/diff/1/third_party/WebKit/Source/m... third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp:62: TraceWrapperMember<WebGLRenderbuffer> m_renderbuffer; On 2016/11/30 14:30:35, haraken wrote: > > How did you notice that these things need to be TraceWrapperMember? visitChildDOMWrappers on WebGLFrameBuffer and the *ContextBase.
The CQ bit was checked by mlippautz@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1480518589821570, "parent_rev":
"7cb1b4d5832f72cbdd134404ab72248e9e2bc45f", "commit_rev":
"c8cb590b46db5b82474cff95e9956055ffd7b32b"}
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [wrapper-tracing] Fix WebGL extension and attachment handling Fixes a wrapper tracing issue where ExtensionTracker and WebGLAttachment were not handled properly. Has no affect on regular Oilpan garbage collection. With wrapper tracing enabled this could've resulting in wrappers for typed extensions and attachments being prematurely collected. The issue was flushed out when we were able to generate compile-time errors instead of having a catch-all dispatcher at runtime in http://crrev.com/2533383003. BUG=chromium:468240 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== [wrapper-tracing] Fix WebGL extension and attachment handling Fixes a wrapper tracing issue where ExtensionTracker and WebGLAttachment were not handled properly. Has no affect on regular Oilpan garbage collection. With wrapper tracing enabled this could've resulting in wrappers for typed extensions and attachments being prematurely collected. The issue was flushed out when we were able to generate compile-time errors instead of having a catch-all dispatcher at runtime in http://crrev.com/2533383003. BUG=chromium:468240 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/fb0beca59e6cc67a6f5b599476c8a3b27ce0418b Cr-Commit-Position: refs/heads/master@{#435262} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/fb0beca59e6cc67a6f5b599476c8a3b27ce0418b Cr-Commit-Position: refs/heads/master@{#435262}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2537223007/ by iclelland@chromium.org. The reason for reverting is: We're seeing failures on a some of the MacOSX WebGL Conformance tests since this landed -- not a lot of tests, but enough that it's showing up regularly in the sheriff queue, and I can see it in the GPU bots as well. This is the only commit in the range that seems to touch both WebGL and memory management, so reverting speculatively. Sorry for that :( Recent crash log: https://chromium-swarm.appspot.com/task?id=32cf819f348ef610&refresh=10&show_r... From build https://build.chromium.org/p/chromium.gpu/builders/Mac%2010.10%20Debug%20%28I... .
Message was sent while issue was closed.
On 2016/11/30 20:26:18, iclelland wrote: > A revert of this CL (patchset #1 id:1) has been created in > https://codereview.chromium.org/2537223007/ by mailto:iclelland@chromium.org. > > The reason for reverting is: We're seeing failures on a some of the MacOSX WebGL > Conformance tests since this landed -- not a lot of tests, but enough that it's > showing up regularly in the sheriff queue, and I can see it in the GPU bots as > well. > > This is the only commit in the range that seems to touch both WebGL and memory > management, so reverting speculatively. Sorry for that :( > > Recent crash log: > https://chromium-swarm.appspot.com/task?id=32cf819f348ef610&refresh=10&show_r... > From build > https://build.chromium.org/p/chromium.gpu/builders/Mac%2010.10%20Debug%20%28I... > . Thanks, on a second look I see an issue with the ExtensionTracker. Will have a look next week.
Message was sent while issue was closed.
mlippautz@chromium.org changed reviewers: + kbr@chromium.org
Message was sent while issue was closed.
I cannot see how this change without wrapper tracing being enabled could cause any failures on the bots. I found 2 minor issues w/ wrapper tracing (which is still disabled on master) and added some more comments. PTAL https://codereview.chromium.org/2539113002/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp (right): https://codereview.chromium.org/2539113002/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp:49: WebGLRenderbufferAttachment() : m_renderbuffer(this, nullptr) {} I think this ctor is unused and doesn't make much sense, since none of the methods lazily creates any WebGLRenderbuffer. https://codereview.chromium.org/2539113002/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp:124: WebGLTextureAttachment() : m_texture(this, nullptr) {} Same here? https://codereview.chromium.org/2539113002/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h (right): https://codereview.chromium.org/2539113002/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h:846: m_extension = T::create(context); This lazy creation is the reason we need to trace the tracker (for incremental tracing). https://codereview.chromium.org/2539113002/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h:886: m_extension(this, nullptr) {} IIUC, then the TypedExtensionTracker should lazily create the extension, keep a reference itself (which is the one we track for wrapper tracing), and announce it to the parent reference provided.
Message was sent while issue was closed.
Description was changed from ========== [wrapper-tracing] Fix WebGL extension and attachment handling Fixes a wrapper tracing issue where ExtensionTracker and WebGLAttachment were not handled properly. Has no affect on regular Oilpan garbage collection. With wrapper tracing enabled this could've resulting in wrappers for typed extensions and attachments being prematurely collected. The issue was flushed out when we were able to generate compile-time errors instead of having a catch-all dispatcher at runtime in http://crrev.com/2533383003. BUG=chromium:468240 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/fb0beca59e6cc67a6f5b599476c8a3b27ce0418b Cr-Commit-Position: refs/heads/master@{#435262} ========== to ========== [wrapper-tracing] Fix WebGL extension and attachment handling Fixes a wrapper tracing issue where ExtensionTracker and WebGLAttachment were not handled properly. Has no affect on regular Oilpan garbage collection. With wrapper tracing enabled this could've resulting in wrappers for typed extensions and attachments being prematurely collected. The issue was flushed out when we were able to generate compile-time errors instead of having a catch-all dispatcher at runtime in http://crrev.com/2533383003. BUG=chromium:468240 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/fb0beca59e6cc67a6f5b599476c8a3b27ce0418b Cr-Commit-Position: refs/heads/master@{#435262} ==========
LGTM https://codereview.chromium.org/2539113002/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp (right): https://codereview.chromium.org/2539113002/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp:49: WebGLRenderbufferAttachment() : m_renderbuffer(this, nullptr) {} On 2016/11/30 21:07:37, Michael Lippautz wrote: > I think this ctor is unused and doesn't make much sense, since none of the > methods lazily creates any WebGLRenderbuffer. Yeah, let's remove. https://codereview.chromium.org/2539113002/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp:124: WebGLTextureAttachment() : m_texture(this, nullptr) {} On 2016/11/30 21:07:37, Michael Lippautz wrote: > Same here? Remove? https://codereview.chromium.org/2539113002/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h (right): https://codereview.chromium.org/2539113002/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h:846: m_extension = T::create(context); On 2016/11/30 21:07:38, Michael Lippautz wrote: > This lazy creation is the reason we need to trace the tracker (for incremental > tracing). Makes sense. We should not do anything non-trivial in traceWrappers (and Oilpan's trace).
Thanks for moving this forward and sorry about the earlier revert. I think we're plagued with the bug in http://crbug.com/666061 and http://crbug.com/537054 so maybe we should pause some of this work until those are addressed. https://codereview.chromium.org/2539113002/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h (right): https://codereview.chromium.org/2539113002/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h:886: m_extension(this, nullptr) {} On 2016/11/30 21:07:38, Michael Lippautz wrote: > IIUC, then the TypedExtensionTracker should lazily create the extension, keep a > reference itself (which is the one we track for wrapper tracing), and announce > it to the parent reference provided. Yes, I think that's right. Sorry for the complexity here. Some of this will be changed in the fix for http://crbug.com/666061 / http://crbug.com/537054 .
On 2016/12/02 02:12:26, Ken Russell wrote: > Thanks for moving this forward and sorry about the earlier revert. > No worries! > I think we're plagued with the bug in http://crbug.com/666061 and > http://crbug.com/537054 so maybe we should pause some of this work until those > are addressed. I assume your big CL fixed the most pressing issue. Will continue here as this is effectively blocking us from shipping the feature. > > https://codereview.chromium.org/2539113002/diff/20001/third_party/WebKit/Sour... > File third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h > (right): > > https://codereview.chromium.org/2539113002/diff/20001/third_party/WebKit/Sour... > third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h:886: > m_extension(this, nullptr) {} > On 2016/11/30 21:07:38, Michael Lippautz wrote: > > IIUC, then the TypedExtensionTracker should lazily create the extension, keep > a > > reference itself (which is the one we track for wrapper tracing), and announce > > it to the parent reference provided. > > Yes, I think that's right. Sorry for the complexity here. Some of this will be > changed in the fix for http://crbug.com/666061 / http://crbug.com/537054 . Simpler is ofc better in this case, but the current solution should also work now. Feel free to refactor at any time and ping me if wrapper tracing issues come up.
Comments addressed by rebasing on master :) On 2016/12/01 01:44:14, haraken wrote: > LGTM > > https://codereview.chromium.org/2539113002/diff/20001/third_party/WebKit/Sour... > File third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp (right): > > https://codereview.chromium.org/2539113002/diff/20001/third_party/WebKit/Sour... > third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp:49: > WebGLRenderbufferAttachment() : m_renderbuffer(this, nullptr) {} > On 2016/11/30 21:07:37, Michael Lippautz wrote: > > I think this ctor is unused and doesn't make much sense, since none of the > > methods lazily creates any WebGLRenderbuffer. > > Yeah, let's remove. > > https://codereview.chromium.org/2539113002/diff/20001/third_party/WebKit/Sour... > third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp:124: > WebGLTextureAttachment() : m_texture(this, nullptr) {} > On 2016/11/30 21:07:37, Michael Lippautz wrote: > > Same here? > > Remove? > > https://codereview.chromium.org/2539113002/diff/20001/third_party/WebKit/Sour... > File third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h > (right): > > https://codereview.chromium.org/2539113002/diff/20001/third_party/WebKit/Sour... > third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h:846: > m_extension = T::create(context); > On 2016/11/30 21:07:38, Michael Lippautz wrote: > > This lazy creation is the reason we need to trace the tracker (for incremental > > tracing). > > Makes sense. We should not do anything non-trivial in traceWrappers (and > Oilpan's trace).
The CQ bit was checked by mlippautz@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from hlopko@chromium.org, haraken@chromium.org Link to the patchset: https://codereview.chromium.org/2539113002/#ps60001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1480932634296980,
"parent_rev": "6c52cb2154624285a0ce6c7fa0d3faeba92e296c", "commit_rev":
"53ad9cddb2a73f383191dacbbbd2fdcb36541793"}
Message was sent while issue was closed.
Description was changed from ========== [wrapper-tracing] Fix WebGL extension and attachment handling Fixes a wrapper tracing issue where ExtensionTracker and WebGLAttachment were not handled properly. Has no affect on regular Oilpan garbage collection. With wrapper tracing enabled this could've resulting in wrappers for typed extensions and attachments being prematurely collected. The issue was flushed out when we were able to generate compile-time errors instead of having a catch-all dispatcher at runtime in http://crrev.com/2533383003. BUG=chromium:468240 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/fb0beca59e6cc67a6f5b599476c8a3b27ce0418b Cr-Commit-Position: refs/heads/master@{#435262} ========== to ========== [wrapper-tracing] Fix WebGL extension and attachment handling Fixes a wrapper tracing issue where ExtensionTracker and WebGLAttachment were not handled properly. Has no affect on regular Oilpan garbage collection. With wrapper tracing enabled this could've resulting in wrappers for typed extensions and attachments being prematurely collected. The issue was flushed out when we were able to generate compile-time errors instead of having a catch-all dispatcher at runtime in http://crrev.com/2533383003. BUG=chromium:468240 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/fb0beca59e6cc67a6f5b599476c8a3b27ce0418b Cr-Commit-Position: refs/heads/master@{#435262} ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== [wrapper-tracing] Fix WebGL extension and attachment handling Fixes a wrapper tracing issue where ExtensionTracker and WebGLAttachment were not handled properly. Has no affect on regular Oilpan garbage collection. With wrapper tracing enabled this could've resulting in wrappers for typed extensions and attachments being prematurely collected. The issue was flushed out when we were able to generate compile-time errors instead of having a catch-all dispatcher at runtime in http://crrev.com/2533383003. BUG=chromium:468240 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/fb0beca59e6cc67a6f5b599476c8a3b27ce0418b Cr-Commit-Position: refs/heads/master@{#435262} ========== to ========== [wrapper-tracing] Fix WebGL extension and attachment handling Fixes a wrapper tracing issue where ExtensionTracker and WebGLAttachment were not handled properly. Has no affect on regular Oilpan garbage collection. With wrapper tracing enabled this could've resulting in wrappers for typed extensions and attachments being prematurely collected. The issue was flushed out when we were able to generate compile-time errors instead of having a catch-all dispatcher at runtime in http://crrev.com/2533383003. BUG=chromium:468240 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/fb0beca59e6cc67a6f5b599476c8a3b27ce0418b Committed: https://crrev.com/3b2400e88f4e7ef5cf0ff0e271a76da5c9d32a0f Cr-Original-Commit-Position: refs/heads/master@{#435262} Cr-Commit-Position: refs/heads/master@{#436263} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/3b2400e88f4e7ef5cf0ff0e271a76da5c9d32a0f Cr-Commit-Position: refs/heads/master@{#436263}
Message was sent while issue was closed.
Hooray! Excited to see this moving forward! |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
