src/elements.cc - Issue 2539093002: [runtime] Port simple String.prototype.indexOf cases to TF Builtin

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/elements.cc

Issue 2539093002: [runtime] Port simple String.prototype.indexOf cases to TF Builtin (Closed)

Patch Set: call runtime for large strings Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/elements.cc

diff --git a/src/elements.cc b/src/elements.cc

index 748b420cda863facede6c0e056da75ad721bd7e8..6644a3c97f6a8b32615640b96ccf8d4bf5b2caae 100644

--- a/src/elements.cc

+++ b/src/elements.cc

@@ -3702,9 +3702,9 @@ MaybeHandle<Object> ArrayConstructInitializeElements(Handle<JSArray> array,

JSArray::Initialize(array, JSArray::kPreallocatedArrayElements);

return array;

- } else if (args->length() == 1 && args->at<Object>(0)->IsNumber()) {

+ } else if (args->length() == 1 && args->at(0)->IsNumber()) {

uint32_t length;

- if (!args->at<Object>(0)->ToArrayLength(&length)) {

+ if (!args->at(0)->ToArrayLength(&length)) {

return ThrowArrayLengthRangeError(array->GetIsolate());

}