src/builtins/builtins-array.cc - Issue 2539093002: [runtime] Port simple String.prototype.indexOf cases to TF Builtin

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/builtins/builtins-array.cc

Issue 2539093002: [runtime] Port simple String.prototype.indexOf cases to TF Builtin (Closed)

Patch Set: call runtime for large strings Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/builtins/builtins-array.cc

diff --git a/src/builtins/builtins-array.cc b/src/builtins/builtins-array.cc

index 198c263723f8cdb7ded549171edf59da9013e64a..ae5ee31ba24620183a890f1ca930aa96a305cef1 100644

--- a/src/builtins/builtins-array.cc

+++ b/src/builtins/builtins-array.cc

@@ -144,7 +144,7 @@ MUST_USE_RESULT static Object* CallJsIntrinsic(Isolate* isolate,

int argc = args.length() - 1;

ScopedVector<Handle<Object>> argv(argc);

for (int i = 0; i < argc; ++i) {

- argv[i] = args.at<Object>(i + 1);

+ argv[i] = args.at(i + 1);

}

RETURN_RESULT_OR_FAILURE(

isolate,