Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 2539063002: Update kernel/binary.md. (Closed)

Created:
4 years ago by Kevin Millikin (Google)
Modified:
4 years ago
Reviewers:
asgerf
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update kernel/binary.md. Update a few things that are out of date and consistently use List for arrays preceded by a UInt length. BUG= R=asgerf@google.com Committed: https://github.com/dart-lang/sdk/commit/bda2c1d53443263bf1687c0e8a8506a65cc6fba3

Patch Set 1 #

Total comments: 2

Patch Set 2 : Reword URI comment. #

Patch Set 3 : Fix typo in comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -22 lines) Patch
M pkg/kernel/binary.md View 1 2 3 chunks +22 lines, -22 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Kevin Millikin (Google)
4 years ago (2016-11-30 10:53:08 UTC) #2
asgerf
LGTM https://codereview.chromium.org/2539063002/diff/1/pkg/kernel/binary.md File pkg/kernel/binary.md (right): https://codereview.chromium.org/2539063002/diff/1/pkg/kernel/binary.md#newcode170 pkg/kernel/binary.md:170: // or file scheme. An application root was ...
4 years ago (2016-11-30 11:14:55 UTC) #3
Kevin Millikin (Google)
https://codereview.chromium.org/2539063002/diff/1/pkg/kernel/binary.md File pkg/kernel/binary.md (right): https://codereview.chromium.org/2539063002/diff/1/pkg/kernel/binary.md#newcode170 pkg/kernel/binary.md:170: // or file scheme. An application root was specified ...
4 years ago (2016-11-30 11:21:00 UTC) #4
Kevin Millikin (Google)
4 years ago (2016-11-30 11:26:09 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
bda2c1d53443263bf1687c0e8a8506a65cc6fba3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698