Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 2539033005: ppapi: Cleanup class/struct forward declarations (Closed)

Created:
4 years ago by jbriance
Modified:
4 years ago
Reviewers:
bbudge, raymes
CC:
chromium-reviews, yusukes+watch_chromium.org, tzik, binji+watch_chromium.org, posciak+watch_chromium.org, teravest+watch_chromium.org, bradnelson+warch_chromium.org, piman+watch_chromium.org, ihf+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ppapi: Cleanup class/struct forward declarations Remove useless class and struct forward declarations, and add missing ones in ppapi header files. BUG=662195 Committed: https://crrev.com/3fc70420614cce741583c6dcb3b4056e5aec365d Cr-Commit-Position: refs/heads/master@{#436167}

Patch Set 1 #

Patch Set 2 : Add missing forward declaration in content/renderer/pepper #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -49 lines) Patch
M content/renderer/pepper/pepper_plugin_instance_impl.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/cpp/dev/file_chooser_dev.h View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/cpp/dev/video_decoder_client_dev.h View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/cpp/instance.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ppapi/cpp/network_monitor.h View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/cpp/private/ext_crx_file_system_private.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ppapi/cpp/private/isolated_file_system_private.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ppapi/cpp/private/pdf.h View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/cpp/text_input_controller.h View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/host/host_factory.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ppapi/host/ppapi_host.h View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/proxy/pdf_resource.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ppapi/proxy/plugin_resource.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ppapi/proxy/ppb_var_deprecated_proxy.h View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/proxy/ppp_instance_proxy.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ppapi/proxy/resource_creation_proxy.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ppapi/proxy/serialized_flash_menu.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ppapi/proxy/tcp_socket_resource_base.h View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/proxy/url_loader_resource.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ppapi/proxy/video_capture_resource.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ppapi/proxy/video_decoder_resource.h View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/proxy/video_encoder_resource.h View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/shared_impl/ppb_var_shared.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ppapi/tests/test_file_io.h View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/tests/test_message_loop.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ppapi/tests/test_url_request.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ppapi/thunk/ppb_instance_api.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ppapi/thunk/ppb_url_loader_api.h View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/thunk/resource_creation_api.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ppapi/utility/websocket/websocket_api.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 18 (13 generated)
jbriance
4 years ago (2016-12-02 17:36:03 UTC) #2
bbudge
Nice, thank you. lgtm
4 years ago (2016-12-02 18:20:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2539033005/20001
4 years ago (2016-12-03 10:56:42 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-03 20:50:15 UTC) #16
commit-bot: I haz the power
4 years ago (2016-12-03 20:53:44 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3fc70420614cce741583c6dcb3b4056e5aec365d
Cr-Commit-Position: refs/heads/master@{#436167}

Powered by Google App Engine
This is Rietveld 408576698