Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2539033004: Fixes #27960 (Closed)

Created:
4 years ago by vsm
Modified:
4 years ago
Reviewers:
Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Reformat #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -7 lines) Patch
M pkg/dev_compiler/lib/src/compiler/code_generator.dart View 1 5 chunks +11 lines, -7 lines 0 comments Download
A pkg/dev_compiler/test/codegen/language/call_function2_test.dart View 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
vsm
4 years ago (2016-12-01 22:46:51 UTC) #3
Jennifer Messerly
lgtm https://codereview.chromium.org/2539033004/diff/1/pkg/dev_compiler/lib/src/compiler/code_generator.dart File pkg/dev_compiler/lib/src/compiler/code_generator.dart (right): https://codereview.chromium.org/2539033004/diff/1/pkg/dev_compiler/lib/src/compiler/code_generator.dart#newcode3546 pkg/dev_compiler/lib/src/compiler/code_generator.dart:3546: JS.Expression _emitFunctionCall(InvocationExpression node, [Expression function]) { do you ...
4 years ago (2016-12-01 23:20:33 UTC) #4
vsm
On 2016/12/01 23:20:33, Jennifer Messerly wrote: > lgtm > > https://codereview.chromium.org/2539033004/diff/1/pkg/dev_compiler/lib/src/compiler/code_generator.dart > File pkg/dev_compiler/lib/src/compiler/code_generator.dart (right): ...
4 years ago (2016-12-01 23:35:24 UTC) #5
vsm
4 years ago (2016-12-01 23:38:54 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
ec81359fc0cfeebe4faf8e91db04ed4b4c7c9685 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698