Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 253903003: Bugfix: internationalization routines fail on monkeypatching. (Closed)

Created:
6 years, 7 months ago by mvstanton
Modified:
6 years, 7 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Bugfix: internationalization routines fail on monkeypatching. Calls to Object.defineProperty() and Object.apply() are not safe. R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21071

Patch Set 1 #

Total comments: 4

Patch Set 2 : Comment response. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -45 lines) Patch
M src/i18n.js View 20 chunks +42 lines, -45 lines 0 comments Download
A test/mjsunit/regress/regress-builtinbust-7.js View 1 1 chunk +30 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
mvstanton
Hey Michael, here is the update, thx! --Michael
6 years, 7 months ago (2014-04-29 16:52:08 UTC) #1
Michael Starzinger
LGTM. https://codereview.chromium.org/253903003/diff/1/test/mjsunit/regress/supported-locales-of.js File test/mjsunit/regress/supported-locales-of.js (right): https://codereview.chromium.org/253903003/diff/1/test/mjsunit/regress/supported-locales-of.js#newcode1 test/mjsunit/regress/supported-locales-of.js:1: // Copyright 2014 the V8 project authors. All ...
6 years, 7 months ago (2014-04-29 20:20:28 UTC) #2
mvstanton
done, thanks! https://codereview.chromium.org/253903003/diff/1/test/mjsunit/regress/supported-locales-of.js File test/mjsunit/regress/supported-locales-of.js (right): https://codereview.chromium.org/253903003/diff/1/test/mjsunit/regress/supported-locales-of.js#newcode1 test/mjsunit/regress/supported-locales-of.js:1: // Copyright 2014 the V8 project authors. ...
6 years, 7 months ago (2014-04-30 07:15:58 UTC) #3
mvstanton
6 years, 7 months ago (2014-04-30 07:36:18 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r21071 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698